Repository navigation
fix(deps): pin SQLQuack 0.11.2 - #80
Merged
Merged
Conversation
Deploying sqlclean with
|
| Latest commit: |
a47b217
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e3810f08.sqlclean.pages.dev |
| Branch Preview URL: | https://fix-pin-sqlquack-0-11-2.sqlclean.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack 0.11.2 is published. Its Snowflake parser now reads object statements it used to reject: procedure argument modes (
order_count OUTPUT INT), alerts, Streamlit apps, listings, services, data movement rules, and backup and snapshot sets. SQLClean reported these as syntax errors. SQLClean and SQLBuild link one SQLQuack, so SQLClean moves first.Changes
sqlquack-*pins inCargo.tomlmove from62642bc1(0.11.1) to7bf03d1a(0.11.2).Cargo.lockupdates only the SQLQuack packages.Verification
cargo test --allpasses (40 + 8 tests), including the format corpus test. The T-SQL lint test stays ignored.make check-cipasses.sqlclean check --no-cacheandsqlclean format:CREATE PROCEDURE refresh_orders (order_count OUTPUT INT) ...andCREATE ALERT late_orders_alert WAREHOUSE = ... IF (EXISTS (...)) THEN SELECT 1;: 0.9.4 reports a syntax error and leaves both unformatted. This build passes every check and formats both. The formatted files still pass, and formatting them again changes nothing.SELECTpasses and keeps its layout on both.