Repository navigation
fix(deps): pin SQLQuack 0.12.1 - #83
Merged
Merged
Conversation
SQLQuack 0.12.1 is published. Its Snowflake parser reads EXECUTE IMMEDIATE and SHOW TASKS ... ROOT ONLY, which SQLClean reported as syntax errors, and refuses a string SEQUENCE_NUMBER in ALTER APPLICATION ... APPROVE SPECIFICATION, which SQLClean accepted. SQLClean and SQLBuild link one SQLQuack, so SQLClean moves first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQLQuack 0.12.1 is published, with three releases of Snowflake parser corrections since 0.11.2. SQLClean reported
EXECUTE IMMEDIATEandSHOW TASKS ... ROOT ONLYas syntax errors, and accepted a stringSEQUENCE_NUMBERinALTER APPLICATION ... APPROVE SPECIFICATION. SQLClean and SQLBuild link one SQLQuack, so SQLClean moves first.Changes
sqlquack-*pins inCargo.tomlmove from7bf03d1a(0.11.2) to75d4c848(0.12.1).Cargo.lockupdates only the SQLQuack packages.Verification
cargo test --all --lockedpasses (40 + 8 tests), including the format corpus test. The T-SQL lint test stays ignored.make check-cipasses.sqlclean check --no-cache:EXECUTE IMMEDIATE 'SELECT order_id FROM orders';: 0.9.5 reports an opaque-node syntax error; this build passes.SHOW TASKS IN DATABASE orders_db ROOT ONLY;: 0.9.5 reports a parse error; this build passes.ALTER APPLICATION orders_app APPROVE SPECIFICATION orders_spec SEQUENCE_NUMBER = '1';: 0.9.5 passes; this build refuses it with "Expected a number after SEQUENCE_NUMBER =".CREATE INTERACTIVE WAREHOUSE orders_wh (order_id INT);: both refuse it; this build says "Expected a property after the warehouse name" instead of an opaque-node error.SELECTpasses on both and formats the same.