Repository navigation
ci: let release PRs update the UI demo's version - #417
Merged
Merged
Conversation
Release Please now writes each release's version into the demo's prepared.json and recorded /api/status, so both release-PR content checks allow those two files.
kvlonge
enabled auto-merge (squash)
November 14, 2026 17:08
Deploying sqltide with
|
| Latest commit: |
2662081
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ceffba6.sqltide.pages.dev |
| Branch Preview URL: | https://ci-allow-demo-version-in-rel.sqltide.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#415 made Release Please write each release's version into the UI demo (
ui/src/lib/demo/prepared.jsonand the recorded/api/statusinrecordings.json). Both release-PR content checks only allow version metadata files, so the 0.70.1 release PR (#416) fails Pull Request Metadata, and the Release Please run on main fails its own validation step.Changes
pull-request-metadata.ymlandrelease-please.yml: the release-PR file allowlists also accept exactly those two demo files. Every other path is still rejected.Verification
ui/src/lib/demo/types.tsis still reported.uv.lockfailure was on the commit before the workflow's own lockfile refresh (f7f829f).