Skip to content

feat(plugin): add configurable base-url and token-url CLI arguments - #66

Merged
jojomo96 merged 2 commits into
mainfrom
feat/configurable-api-endpoints
Nov 17, 2026
Merged

jojomo96 merged 2 commits into
mainfrom
feat/configurable-api-endpoints

Conversation

@jojomo96

Copy link
Copy Markdown
Member

Summary

Adds optional --dns-stackit-base-url and --dns-stackit-token-url CLI arguments so the authenticator can target custom STACKIT DNS API and Service Account token endpoints (matching the flags in external-dns-stackit-webhook).

Changes

  • certbot_dns_stackit/stackit.py:
    • Add --dns-stackit-base-url CLI argument (default: https://dns.api.stackit.cloud), while preserving backwards compatibility with dns_stackit_base_url in credentials INI files and stripping trailing slashes.
    • Add --dns-stackit-token-url CLI argument (default: https://service-account.api.stackit.cloud/token) for service account JWT token exchange.
  • certbot_dns_stackit/test_stackit.py:
    • Add unit tests for custom --dns-stackit-token-url, custom --dns-stackit-base-url with service account authentication, and base_url via INI credentials.
  • README.md:
    • Document --dns-stackit-base-url and --dns-stackit-token-url in the arguments table.

@jojomo96
jojomo96 requested a review from a team November 17, 2026 10:52
ondbeh
ondbeh previously approved these changes Nov 17, 2026
@jojomo96
jojomo96 merged commit ce77b27 into main Nov 17, 2026
4 checks passed
@jojomo96
jojomo96 deleted the feat/configurable-api-endpoints branch November 17, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants