Repository navigation
test(assistant): fix folder-naming database fixture blocking release builds - #265
Merged
Merged
Conversation
lweberru
requested review from
Breeless,
JoshSTACKIT,
LembDo and
dweezl
as code owners
November 17, 2026 11:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Configurator Release build fails in the PostgreSQL integration suite after #264: its folder-naming model fixture still returns the old
changes.rm_foldersresponse and omits the required structuredfolderNamesfield. The early failure leaves its own test configuration behind, causing the subsequent pooled-identity assertion to see an extra row for the same test user.Update the fixture to the current model contract, assert that the emitted schema requires names for the existing folder keys, and register test-local cleanup with
onTestFinishedso failure paths also remove the configuration. Existing assertions for proposal acceptance, identity preservation, metadata privacy and tenant isolation remain intact. Application code, model prompts and validation rules are unchanged.Validation: reproduced both reported failures locally on the exact CI PostgreSQL image
postgres@sha256:d74eeac9a635390a49bc21bd49fccd973de707e2a53a76ac49b552b8712ec46f; after correction all 55 identity tests pass. The complete CI database command passes with 223 tests and one existing skip across all 10 files. Typecheck, changed-file Biome checks andgit diff --checkpass. The temporary local database container was removed; no cloud deployment or live model calls were performed.Follow-up to #263 / #264. Failed release: https://github.com/stackitcloud/stackit-landing-zone/actions/runs/44075554893/job/134012509901. That run never reached deployment. After merge, start a new Configurator Release from updated
main; rerunning the old run retains its original source revision.