Skip to content

fix(assistant): guide incomplete setup into scoped questions - #270

Merged
lweberru merged 1 commit into
mainfrom
fix/assistant-central-git
Nov 17, 2026
Merged

lweberru merged 1 commit into
mainfrom
fix/assistant-central-git

Conversation

@lweberru

@lweberru lweberru commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

A short central-Git setup request could end in the unconfirmed-model-details error. Native Editor source checks correctly reject invented values, but the error mapping ended the dialogue. The central corpus covered advice and fully specified Git changes while missing ordinary setup and follow-up requests.

Keep rejected proposals unapplied and ask a scoped follow-up within the existing public question contract. Catalogue-grounded recommendations remain reviewable proposals. For new Git instances, require size/access decisions, discard partial proposals while a question remains open, use actual networks as free text, and prevent unrelated project/region questions. Make response language explicit in the model contract and instruction.

Extend the maintained central corpus with short English/German requests, partial selections, completion after questions, language checks and a Git setup step in the continuous journey. Keep source/schema/secret/IAM guards and acceptance/saving/execution boundaries. Update both knowledge runbooks and regenerate source-bound topic and case inventories.

Validation:

  • Complete npm run check: 1,849 passed, 78 existing skips; lint, typechecks and build pass.
  • 430 focused Editor/scenario tests pass, including unconfirmed product/contact/network rejection, zero applied changes, catalogue recommendations and both-language partial creation.
  • Final real-model qualification on the configured Qwen answer/intent model: all 14 Git checks passed (seven cases, each independently twice), and all 14 continuous-journey steps passed. Both bind to knowledge SHA-256 214d7e81d145ea5fa6d74cbf8e174a1b9fe8b164ac37460626108582b8af0a8b. Earlier failed intermediate receipts are retained and are not counted as successful qualification. This is targeted qualification, not a claim that all Assistant topics are fully qualified.

No deployment or release is part of this PR. Closes #269.

@lweberru
lweberru marked this pull request as ready for review November 17, 2026 15:36
@lweberru
lweberru merged commit 1bcffb7 into main Nov 17, 2026
16 checks passed
@lweberru
lweberru deleted the fix/assistant-central-git branch November 17, 2026 16:22
lweberru added a commit that referenced this pull request Nov 17, 2026
Add concise curated notes for v2.1.2 so the requested Dev build can
subsequently be published and promoted unchanged to production. The
release contains the reviewed Assistant setup-dialogue fix from #270:
scoped follow-ups for unconfirmed values, complete Git setup decisions,
and English/German dialogue regressions.

Validation: all seven production helper tests pass; v2.1.2 notes render
correctly in `skip` mode and retain the known Assistant qualification
limitation. No runtime, workflow, permissions or infrastructure changes.

The requested rollout remains Dev first, then Prod using the same
successful immutable build. Full Assistant qualification is not claimed;
targeted source-bound checks for #270 passed 14/14 Git checks and 14/14
journey steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(assistant): turn incomplete central Git setup into a guided dialogue

1 participant