Skip to content

refactor!: replace Pigeon with the threat event channel - #244

Merged
tompsota merged 3 commits into
feat/unified-apifrom
feat/drop-pigeon
Nov 13, 2026
Merged

tompsota merged 3 commits into
feat/unified-apifrom
feat/drop-pigeon

Conversation

@tompsota

Copy link
Copy Markdown
Member

Stacked on #243 (feat/unified-api). Removes Pigeon from the plugin.

Why

Pigeon carried only two Android-to-Dart calls (onMalwareDetected, onOngoingCallDetected) and three types. Everything else already used hand-written channels. Because of that split, malware and ongoing call reached Dart on a separate channel from the other threats, with its own registration, and the generated TalsecPigeonApi leaked into the public API as the superclass of ThreatCallback.

What changes

Transport

  • Android sends every detection on the existing threat EventChannel (talsec.app/freerasp/events):
    • a plain threat as its int code (unchanged)
    • malware as {type: "malware", suspiciousApps: [...]}
    • ongoing call as {type: "ongoingCall", state: "started" | "ongoing" | "stopped"}
  • ThreatDispatcher has a single sink and cache. Malware app details are resolved in PluginThreatHandler when the detection arrives.
  • iOS already sends only ints and is unchanged.

Dart

  • attachListener uses one subscription and dispatches ints and maps in arrival order.
  • An unknown code, unknown payload or malformed payload terminates the app, as an unknown threat code already does.
  • onThreatDetected stays Stream<Threat> and skips the payload events.

Types

  • PackageInfo, SuspiciousAppInfo and CallState are hand-written under the same names.
  • They are immutable, with value equality and toString.
  • fromMap is @internal.

Removed

  • pigeons/, the generated Dart and Kotlin, and the pigeon dev dependency.

Breaking (in CHANGELOG)

  • ThreatCallback no longer extends TalsecPigeonApi, and onMalwareDetected/onOngoingCallDetected are gone. Use the onMalware/onOngoingCall callbacks.
  • PackageInfo/SuspiciousAppInfo fields are final and encode/decode are removed.

Verified

  • flutter analyze is clean and 91 tests pass, including new tests:
    • ordered delivery of threat, malware and call-state events
    • onThreatDetected filtering out payload events
    • fromMap parsing and its failure on a malformed map
  • The example debug APK builds.
  • On the Pixel 4 emulator (API 33):
    • the malware sheet lists the suspicious apps with names, reasons and icons
    • threats and execution states are shown
    • the OngoingCall row goes Not detected → Started → Stopped through a real (emulated) call
  • The first run hit an ANR while the freshly booted emulator was overloaded (load 34, main thread idle in its message loop). A clean relaunch showed no ANR.
  • iOS not run; its code is untouched.

🤖 Generated with Claude Code

Malware and ongoing call detections are sent over the existing threat
EventChannel as {type, ...} maps next to the plain threat codes, so one
subscription delivers every detection in order. PackageInfo,
SuspiciousAppInfo and CallState become hand-written Dart types with the
same names; ThreatCallback no longer extends the generated
TalsecPigeonApi. The pigeon dev dependency and generated code are removed.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@tompsota
tompsota added this pull request to stack #245 November 12, 2026 09:17
tompsota and others added 2 commits November 12, 2026 10:30
flutter/foundation does not export @internal in Flutter 3.24, the minimum
supported version used by CI.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@tompsota
tompsota removed this pull request from stack #245 November 13, 2026 22:04
@tompsota
tompsota merged commit dabf39d into feat/unified-api Nov 13, 2026
6 checks passed
@tompsota
tompsota deleted the feat/drop-pigeon branch November 13, 2026 22:04
tompsota added a commit that referenced this pull request Nov 13, 2026
* feat!: unify the public API with the other freeRASP plugins

- config fields follow the native SDKs: AndroidConfig.certificateHashes,
  supportedAlternativeStores; IOSConfig.appBundleIds, appTeamId
- threat names match the other plugins: onAdbEnabled, onUnsecureWifi,
  Threat.deviceID, Threat.unsecureWifi
- every method throws only TalsecException or a subclass; new
  UnsupportedPlatformException replaces UnimplementedError, and the
  malware/external-id exceptions are now exported

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* test(ios): use the renamed config keys in RunnerTests

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* refactor!: hide Talsec internals, tighten malware callback, unify unknown-code handling

- Talsec.private and the channel fields are private; tests use an
  internal createTalsecForTesting factory that freerasp.dart hides
- MalwareCallback takes List<SuspiciousAppInfo> suspiciousApps
- ThreatX.fromInt throws ArgumentError; Talsec terminates the app on an
  unknown threat or execution state code, like the JS plugins

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix: use @VisibleForTesting for the test factory

@internal is not exported by flutter/foundation in Flutter 3.24, the
minimum supported version used by CI.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* refactor!: replace Pigeon with the threat event channel (#244)

* refactor!: replace Pigeon with the threat event channel

Malware and ongoing call detections are sent over the existing threat
EventChannel as {type, ...} maps next to the plain threat codes, so one
subscription delivers every detection in order. PackageInfo,
SuspiciousAppInfo and CallState become hand-written Dart types with the
same names; ThreatCallback no longer extends the generated
TalsecPigeonApi. The pigeon dev dependency and generated code are removed.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix: import @internal and @immutable from package:meta

flutter/foundation does not export @internal in Flutter 3.24, the minimum
supported version used by CI.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
tompsota added a commit that referenced this pull request Nov 13, 2026
* release: freeRASP 8.4.0 (Android SDK 20.0.1)

Bump the Android SDK to 20.0.1 (app.talsec.rasp:TalsecRasp-Community-Flutter)
and expose its new features:

- ongoing call detection: ThreatCallback.onOngoingCall with CallState,
  Talsec.startOngoingCallDetection/stopOngoingCallDetection
- screen control blocking: blockScreenControl/isScreenControlBlocked
- overlay windows hiding: blockOverlayWindows/isOverlayWindowsBlocked
- onCriticalChecksFinished/onPostponedChecksFinished execution states

onAllChecksFinished is now driven by the SDK's onFastChecksFinished, which
fires where the removed onAllChecksFinished used to.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs: reword the Maven coordinates changelog entry

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* feat!: rename allChecksFinished to fastChecksFinished

The execution state that fires when the fast (standard) checks complete is
renamed on all platforms to match the Android SDK's onFastChecksFinished. On
iOS it is driven by the SDK's onAllChecksFinished. This is a breaking change,
so the package major version is bumped.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs: drop Breaking markers from Android SDK changes absorbed by the plugin

The plugin hides these native API changes from its users, so they move from
the Android Breaking Changes section to Changed.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs: drop Android changelog entries already listed in the plugin section

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* refactor(android): move plugin to the app.talsec.rasp.flutter namespace (#242)

* refactor(android): move plugin to the app.talsec.rasp namespace

Align the Android package of the plugin with the Android SDK's app.talsec.rasp,
adding the platform as the last segment.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* refactor(android): update package names to app.talsec.rasp

Completes the move of the plugin sources: package declarations, imports,
Gradle namespace and build configuration.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>

* example: show ongoing call alongside the other threats

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* example: show the ongoing call state (Not detected, Started, Ongoing, Stopped)

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* feat(android): start Talsec in background mode

Talsec.start now uses TalsecMode.BACKGROUND, as the React Native plugin
already does, so the SDK initializes off the calling thread.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* docs(changelog): note that freeRASP starts in background mode on Android

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* feat!: unify the public API with the other freeRASP plugins (#243)

* feat!: unify the public API with the other freeRASP plugins

- config fields follow the native SDKs: AndroidConfig.certificateHashes,
  supportedAlternativeStores; IOSConfig.appBundleIds, appTeamId
- threat names match the other plugins: onAdbEnabled, onUnsecureWifi,
  Threat.deviceID, Threat.unsecureWifi
- every method throws only TalsecException or a subclass; new
  UnsupportedPlatformException replaces UnimplementedError, and the
  malware/external-id exceptions are now exported

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* test(ios): use the renamed config keys in RunnerTests

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* refactor!: hide Talsec internals, tighten malware callback, unify unknown-code handling

- Talsec.private and the channel fields are private; tests use an
  internal createTalsecForTesting factory that freerasp.dart hides
- MalwareCallback takes List<SuspiciousAppInfo> suspiciousApps
- ThreatX.fromInt throws ArgumentError; Talsec terminates the app on an
  unknown threat or execution state code, like the JS plugins

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix: use @VisibleForTesting for the test factory

@internal is not exported by flutter/foundation in Flutter 3.24, the
minimum supported version used by CI.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* refactor!: replace Pigeon with the threat event channel (#244)

* refactor!: replace Pigeon with the threat event channel

Malware and ongoing call detections are sent over the existing threat
EventChannel as {type, ...} maps next to the plain threat codes, so one
subscription delivers every detection in order. PackageInfo,
SuspiciousAppInfo and CallState become hand-written Dart types with the
same names; ThreatCallback no longer extends the generated
TalsecPigeonApi. The pigeon dev dependency and generated code are removed.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

* fix: import @internal and @immutable from package:meta

flutter/foundation does not export @internal in Flutter 3.24, the minimum
supported version used by CI.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant