Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpWaitStrategy.from_url("http://localhost:8080/health?ready=true")currently sendsGET /health, dropping the query string. Health endpoints that require query parameters can therefore time out or validate the wrong request. Theurlparsecall also drops semicolon parameters from the final path segment.Preserve the complete request target with
urlsplit, and append the original query without decoding or re-encoding it. Fragments remain excluded from HTTP requests; port and TLS handling are unchanged.Validation on main at
6146aa1170f415fcc825ed9bddc4eacbeb937a12:127.0.0.1confirm the actual request targets, including repeated/blank parameters, encoded characters, semicolon path parameters, root paths and fragments. The mapped-port target is a stub, not a Docker container._RestartPolicyexport and fourNetworkCollection.listcalls); no new diagnostics. The changed source file typechecks.The local Docker Desktop API did not respond to bounded probes, so Docker integration tests were not run. Python 3.13; mypy 2.3.0 and types-docker 7.2.0.20260728 were taken from
uv.lock.