Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
GNU testsuite comparison: |
Merging this PR will regress 2 benchmarks3 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
591f2d7 to
b556e2c
Compare
|
/rerun |
| print_feature("avx512", features.has_avx512()); | ||
| print_feature("avx2", features.has_avx2()); | ||
| print_feature("pclmul", features.has_pclmulqdq()); | ||
| print_feature("pclmul", features.has_avx() && features.has_pclmulqdq()); |
There was a problem hiding this comment.
please explain why pclmul is conditional on avx
There was a problem hiding this comment.
This matches GNU's behaviour: pclmul_supported() in cksum_crc.c gates on avx && pclmul, because that path is compiled with -mavx -mpclmul so it genuinely needs both, and the not-detected message is printed from that same value. Keeping the same conjunction keeps our --debug output aligned with GNU's.
There was a problem hiding this comment.
Please remove the unrelated change from this PR and open an issue to track it.
b556e2c to
e28e9d1
Compare
e28e9d1 to
6152c9e
Compare
Correct the hardware capability mapping for
PMULLand accept the fullPCLMULQDQname.Add a regression test for both capability names.
Closes #16434