Skip to content

Upgrade rust crate notify to v9 - #16620

Draft
xtqqczze wants to merge 4 commits into
uutils:mainfrom
xtqqczze:deps/notify
Draft

xtqqczze wants to merge 4 commits into
uutils:mainfrom
xtqqczze:deps/notify

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

This PR contains the following updates:

Package Type Update Change
notify workspace.dependencies major 8.2.2 → 9.0.0

Release Notes

notify-rs/notify (notify)

v9.0.0: notify: v9.0.0

Compare Source

No significant change since v9-rc, see https://github.com/notify-rs/notify/blob/main/docs/UPGRADING_V8_TO_V9.md for details.


Closes #16627.

@xtqqczze
xtqqczze force-pushed the deps/notify branch 2 times, most recently from e996002 to 042f269 Compare November 17, 2026 15:22
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 155.36 MB (+204 KB, +0.13%)

Significant per-binary changes:
  tail     1.60 MB ->    1.80 MB  (+208 KB, +12.68%)

@xtqqczze xtqqczze closed this Nov 18, 2026
@xtqqczze xtqqczze self-assigned this Nov 18, 2026
@xtqqczze xtqqczze reopened this Nov 21, 2026
@xtqqczze
xtqqczze force-pushed the deps/notify branch 2 times, most recently from d00c824 to 6964c5c Compare November 21, 2026 11:41
@codspeed

codspeed Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

1 warning, 1 note

⚠️ 39 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

ℹ️ This run is excluded from the branch history

This commit was force-pushed, so this run no longer appears in the branch's performance history.

✅ 63 untouched benchmarks
⏩ 420 skipped benchmarks1


Comparing xtqqczze:deps/notify (c1be985) with main (f21dd53)2

Open in CodSpeed

Footnotes

  1. 420 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (6c6ed73) during the generation of this report, so f21dd53 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@xtqqczze

Copy link
Copy Markdown
Collaborator Author

Blocked by #16750.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump MSRV to 1.91

1 participant