Repository navigation
dd: extend a sparse output before syncing it - #16641
yunusarda-sudo wants to merge 1 commit into
Conversation
|
Binary size comparison: |
773be17 to
e677211
Compare
| #[cfg(target_os = "linux")] | ||
| #[cfg(not(wasi_runner))] |
There was a problem hiding this comment.
Move the cfg above the #[rstest], and turn the wasi_runner cfg into a #[uutests::wasi_ignore(reason)] with the right reason (to be choosed among the choices in tests/uutests_procs/src/lib.rs)
There was a problem hiding this comment.
Done in 80b81ec: moved the cfg above #[rstest] and replaced cfg(not(wasi_runner)) with #[uutests::wasi_ignore(NoSubprocessSpawning)], since the test spawns strace.
There was a problem hiding this comment.
Nice ! One last thing, can you squash all your commits in a single one ? Thank you !
e677211 to
7d5ff17
Compare
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
|
GNU testsuite comparison: |
ef33a22 to
71d1789
Compare
With
conv=sparse,fsync(orfdatasync), a trailing zero block is skipped and the file is grown withset_len()only after the sync, so the final length change is outside the requested synchronization. GNU dd extends the file first and then syncs.finalize()now callsextend_sparse()beforesync(). Added a Linux test that runs dd understrace(skipped when strace is missing or tracing isn't allowed, like the existing shred test) and checks that the finalftruncatecomes beforefsync/fdatasync.Closes #16552