Repository navigation
Conversation
|
Binary size comparison: |
| }; | ||
|
|
||
| // The header is laid out on the page width, which -J leaves alone. | ||
| let header_width = matches |
There was a problem hiding this comment.
-W is already parsed and validated above for page_width, could we reuse that instead of parsing it again here?
for example, parse it once before the -J check and use it for both
There was a problem hiding this comment.
Done, it is parsed once before the -J check and used for both. This also makes pr -J -W x fail like without -J, as GNU does; added a case for it.
Merging this PR will improve performance by 8.09%3 warnings, 1 note
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
3f0bbbf to
5ef271c
Compare
Closes #16657
The header was centred in 72 columns whenever
-Jwas given, and when the width came from-wwithout columns. It now uses the page width in those cases as well, aspr -W Nalready did.