Repository navigation
Conversation
A leading -C returned Verbatim from the script handler, so `vp -C <dir> check` and `vp -C <dir> lint` in a cached task never attached their tracked env vars. Keep the original command for the child, but synthesize it with the cache config the subcommand would use.
Author
|
this PR relies on the underlying cwd fix in voidzero-dev/vite-task#1005. Please ensure #1005 is merged first before merging this one. The cache config logic has been factored out to avoid drift. Local tests (79 passed) and clippy are all green |
Collaborator
|
Thanks for the PR. |
Author
|
Understood |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3503
A leading
-CreturnedVerbatimfrom the script handler, sovp -C <dir> check/vp -C <dir> lintin a cached task skipped the cache config their direct counterparts get.OXLINT_TSGOLINT_PATHwas neither fingerprinted nor passed through, so changing it replayed a stale cache, andcheckalso ignoredVP_SKIP_STATIC_CONFIG.The command now stays untouched (the child still applies the chdir and reports bad targets) but is synthesized with the subcommand's cache config. The configs are factored out of
SubcommandResolver::resolveso the normal and-Cpaths cannot drift. This also restorestest/packinput exclusions and the disabled cache fordev/previewbehind-C.Tests:
cargo test -p vite-plus-cli --lib(79 passed),cargo clippy -p vite-plus-cli --lib --tests -- -D warnings,cargo fmt --check.