Skip to content

chore(deps): remove an advisory ignore entry that no longer matches Cargo.lock - #1007

Open
zyl71 wants to merge 1 commit into
voidzero-dev:mainfrom
zyl71:remove-stale-advisory-ignores
Open

zyl71 wants to merge 1 commit into
voidzero-dev:mainfrom
zyl71:remove-stale-advisory-ignores

Conversation

@zyl71

@zyl71 zyl71 commented Nov 21, 2026

Copy link
Copy Markdown

Closes #1006

deny.toml still ignores the advisory below, but Cargo.lock on main already holds a patched version of the crate, so the entry no longer suppresses anything. This pull request removes it, together with the comments that explained it.

Advisory Summary In Cargo.lock now Patched in Severity
RUSTSEC-2024-0399 rustls network-reachable panic in Acceptor::accept rustls 0.23.46 0.23.0, 0.23.18 not scored

Why remove it. An ignore entry keeps muting the advisory id for as long as it stays in the file. If the crate were later pinned back to an affected version, cargo-deny would stay silent about it.

What was checked, and what was not.

  • Read from main at commit 42d4ee78f551 on 2026-11-21: the id is on an active line of the config, and no version of the affected crate in Cargo.lock is inside the affected range of its advisory (RustSec records).
  • The change touches only deny.toml. No Rust source and no lock file is changed. The edited file parses as TOML, and every other ignore entry and setting is unchanged.
  • We did not run cargo deny check advisories locally, because we do not build or execute anything from this repository. CI is the first run of the tool on this change.

Not part of this change, but possibly useful: cargo-deny reports such entries as advisory-not-detected warnings, and unused-ignored-advisory = "deny" under [advisories] turns them into errors.

Disclosure: the check, the edit and this text were produced with automated tooling, including an LLM.

Feel free to close this if it is not useful.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore entry for RUSTSEC-2024-0399 no longer matches anything (rustls is already at 0.23.46)

1 participant