Repository navigation
fix: support pnpm workspaces and --no-install - #894
Draft
yuikisaito wants to merge 7 commits into
Draft
yuikisaito wants to merge 7 commits into
yuikisaito wants to merge 7 commits into
Conversation
yuikisaito
force-pushed
the
issue-888
branch
from
November 21, 2026 11:28
59f8386 to
4325273
Compare
yuikisaito
marked this pull request as ready for review
November 21, 2026 11:54
yuikisaito
marked this pull request as draft
November 21, 2026 16:36
Author
|
While implementing #888, I noticed some overlap with
Would you prefer to include this cleanup in this PR, or keep the current scope? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where running
create-voidinside an existing pnpm monorepo unconditionally created a nestedpnpm-workspace.yamlin the target subdirectory, causingpnpm installto treat the subdirectory as an isolated workspace root.When
pnpmis detected,create-voidnow locates the enclosing workspace root and merges Void's requiredallowBuildsentries into the rootpnpm-workspace.yamlwhile preserving existing workspace settings, comments, and build approvals.Remaining Tasks
allowBuildsinto rootpnpm-workspace.yaml--no-installflag to skip running local package installationRelated Issues
Fixes #888