Skip to content

[!!!][TASK] Stop building storage, vsftp and ssh - #597

Merged
Kanti merged 4 commits into
webdevops:masterfrom
andersundsehr:chore/drop-storage-vsftp-ssh
Nov 8, 2026
Merged

Kanti merged 4 commits into
webdevops:masterfrom
andersundsehr:chore/drop-storage-vsftp-ssh

Conversation

@Kanti

@Kanti Kanti commented Nov 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

The images webdevops/storage, webdevops/vsftp and webdevops/ssh are no longer built:

  • storage was FROM alpine:latest and added nothing to it.
  • vsftp and ssh had very few pulls. In 24 hours (2026-11-07/08), without the automated pulls right after the nightly build: vsftp 32, storage 19, ssh 4; php-nginx had about 3,000. ssh has not been built since December 2022.

Their last images stay on Docker Hub without updates.

Changes

  • Removed the three image directories, the ssh and vsftp templates, the ftp() macro, provisioning/vsftp/ with its entry in conf/provision.yml, and their serverspec tests.
  • .github/workflows/build.yaml regenerated: only the storage and vsftp jobs are gone.
  • Makefile groups, conf/diagram.yml and ci/BLACKLIST no longer list the three images.
  • Docs: new docs/discontinued-images.md with starting points for replacements (alpine or a named volume, garethflowers/ftp-server, lscr.io/linuxserver/openssh-server). Removed the storage and vsftp pages, the FTP variables and the vsftp service; clarified what toolbox contains.

How it was verified

  • make provision: no change in docker/ apart from the removed directories.
  • ci/console github:generate-ci: only the storage and vsftp jobs removed.
  • Each replacement example run as documented: FTP upload and listing, SSH key login as application (UID 1000), a named volume that keeps its data.
  • Doc checks: links and anchors resolve, tag lists match build.yaml.

Checks in detail: andersundsehr#5.

Kanti added 4 commits November 8, 2026 07:59
webdevops/storage only re-tagged alpine:latest, webdevops/vsftp and
webdevops/ssh served few pulls (ssh was not built since December 2022).

- Remove their image directories, templates, vsftp provisioning,
  serverspec tests and the FTP environment macro
- Regenerate .github/workflows/build.yaml without their jobs
- Drop them from the Makefile groups, the image graph and the CI
  blacklist
- Docs: remove the image pages, the FTP variables and the vsftp
  service; list the three images as no longer built
docs/discontinued-images.md shows what to use instead of storage
(alpine or a named volume), vsftp (garethflowers/ftp-server, with a
variable mapping) and ssh (a three-line Dockerfile on base-app).
docs/README.md, known-issues.md and AGENTS.md link to it.
base-app is going to be discontinued too, so the replacement for
webdevops/ssh no longer builds on it. The page now uses
lscr.io/linuxserver/openssh-server with the user application
(UID/GID 1000), key login and a table that maps the old setup.
- docs/README.md: toolbox stores the scripts under /baselayout; only
  go-replace is on its PATH (matches the tool table)
- customization.md: say that toolbox only stores the commands
- discontinued-images.md: the examples are a starting point and use
  the latest tag of third-party images; pin them for production
- Remove the serverspec collection::ssh and ssh::layout examples,
  which no spec uses since ssh_spec.rb is gone
@sonarqubecloud

sonarqubecloud Bot commented Nov 8, 2026

Copy link
Copy Markdown

@Kanti
Kanti marked this pull request as ready for review November 8, 2026 09:15
@Kanti
Kanti merged commit 15d2ac6 into webdevops:master Nov 8, 2026
177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant