Repository navigation
wolfterm: fix CSI erase modes and SGR on Windows - #1390
Open
ejohnstown wants to merge 3 commits into
Open
ejohnstown wants to merge 3 commits into
ejohnstown wants to merge 3 commits into
Conversation
Contributor
Author
|
@claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1390
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Max
The Windows console translator handles ED and EL modes as ECMA-48 does: an omitted mode is 0, mode 0 erases from the cursor to the end, mode 1 from the start through the cursor cell, and mode 2 the whole display or line. Mode 1J now clears the display rows above the cursor too. - ED 0-2 keep the scrollback above the console window; a window that does not hold the cursor is moved to it first - ED 0 and 2 clear through the last buffer row, because CSI H addresses buffer rows and `clear` would otherwise leave old text below the first screen - wolfSSH_ClearScreen() wraps at the buffer width, not the maximum window width Issue: F-10556, F-12549
doDisplayAttributes() starts from the current console attributes, applies each SGR argument to that value in order, and sets the result once, so ESC[1;31m keeps the bold. SGR 0 resets to the default attributes mid-sequence. - SGR 25 (blink off) is a no-op; there is no blink to turn off Issue: F-11663, F-15506
test_wolfSSH_ConvertConsole_csi() runs ED, EL and SGR sequences against an off-screen console buffer and reads back the cells and attributes. It repeats ED 0-2 with the window scrolled down two rows to check that the rows outside it are kept. It returns early when no console is attached. Issue: F-10556, F-12549, F-11663, F-15506
ejohnstown
force-pushed
the
wolfterm-csi
branch
from
November 11, 2026 23:37
05eca68 to
da69199
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows console translator handles ED and EL modes 0-2 as ECMA-48
does and keeps every SGR attribute in one sequence.
Issue: F-10556, F-11663, F-12549, F-15506