Repository navigation
internal: try the client's key before a password - #1391
Open
ejohnstown wants to merge 2 commits into
Open
ejohnstown wants to merge 2 commits into
ejohnstown wants to merge 2 commits into
Conversation
ejohnstown
force-pushed
the
userauth-method-order
branch
from
November 11, 2026 22:13
a099da8 to
1a63956
Compare
Contributor
Author
|
@claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1391
Scan targets checked: wolfssh-src, wolfssh-bugs
Not reviewed (no scan target covers them): apps/wolfsshd/test/sshd_permitroot_prohibit_password.sh
Coverage: 7 of 7 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Max
A key or certificate refused by policy now gets USERAUTH_FAILURE instead of a disconnect, as in OpenSSH sshd, so a client that tries its key first can still go on to a password. - PubkeyAuthentication no - a root key under PermitRootLogin forced-commands-only without a ForceCommand - a certificate when a Match block overrides TrustedUserCAKeys, or when the build cannot bind it to the user without FPKI or an AuthorizedKeysFile Issue: F-7640
SendUserAuthRequest() picks the method in the client's order, publickey, then keyboard-interactive, then password, as OpenSSH and Dropbear do; the server's list only says what is on offer. DoUserAuthFailure() offers the key once and a password or keyboard-interactive up to three times. - a callback success with no public key counts as a decline, and a decline is the one key try - a key the server's signature algorithms rule out is skipped - a client with nothing left to offer fails with WS_USER_AUTH_E - drop the TPM-only publickey preference; portfwd asks only for a password - regress: key first, password-only server, fallback, the bound and the three-method order Issue: F-7640
ejohnstown
force-pushed
the
userauth-method-order
branch
from
November 11, 2026 23:37
1a63956 to
ecb0b31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client picks userauth methods in its own order, publickey, then
keyboard-interactive, then password, as OpenSSH does. The key is offered
once and the others up to three times.
refused by policy, so the client can go on to a password
Issue: F-7640