Repository navigation
Correct comments that disagree with the code - #1393
Conversation
|
@claude review |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1393
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 13 of 14 in-scope changed file(s) opened by the reviewer; not opened: wolfssh/error.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Max
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.
LGTM. This change only edits comments, and the two inline nits are about comment wording. Neither affects behavior.
Extended reasoning...
The diff changes comments in 14 files: 57 lines added and 53 removed. Every changed line is inside a comment, so no executable code changes. It edits text in auth, KEX, SCP, SFTP and agent sources but changes nothing in how those paths run. The two inline findings are wording nits in ssh.h and internal.c. Approval rests on the change being comment-only and on the hunt finishing with a dry streak.
Comment-only change: each comment now describes what its code does.
No code tokens change.
- kex: server f is our output, not the peer key; the ML-KEM-768 f is
the ciphertext; the client hybrid also covers P-256 and P-384
- scp: base path and fd referents, NEW_REQUEST state, unchanged index,
oversize rejection, and where the symlink checks are not atomic
- error.h: WS_DH_SIZE_E and WS_DISCONNECT meanings, GetErrorString()
- api: stream_read WS_EXTDATA, channel-open built-in refusals, write
ctx, SFTP write offset, agent reply status, userauth returns
- misc: off_t guess, wSelect, handle cap, sftpclient, wolfsshd notes
Issue: F-9422, F-10564, F-11637, F-11638, F-11639, F-11640, F-12555,
F-12556, F-13915, F-14207, F-14399, F-15514, F-15515, F-15516,
F-16055, F-16056, F-16057, F-16757, F-16758, F-16759, F-16760,
F-16761, F-16762, F-16763, F-17054, F-17055, F-17868, F-17869
2954d84 to
ee1c8d1
Compare
Comment-only change: each comment now matches what its code does.
Issue: F-9422, F-10564, F-11637, F-11638, F-11639, F-11640, F-12555,
F-12556, F-13915, F-14207, F-14399, F-15514, F-15515, F-15516,
F-16055, F-16056, F-16057, F-16757, F-16758, F-16759, F-16760,
F-16761, F-16762, F-16763, F-17054, F-17055, F-17868, F-17869