Repository navigation
Carry the open app/v3 pull requests that integrate cleanly onto dev (16 of 22) - #2597
Merged
Merged
Conversation
One conflict, in the factory worker's start: #2596 made the worker ask what its machine lacks before every lease poll, and #2570 keeps that word where lost-runner recovery reads it. Both are kept: each poll's answer is stored. Co-Authored-By: Claude Fable 5.2 <[email protected]>
Co-Authored-By: Claude Fable 5.2 <[email protected]>
…entity Custody now creates a quiet local profile on first save. Establish the shared fixtures paired premise before that save so Ensure does not preserve an unintended solo marker. Keep every notice, read-count, ownership, and explicit solo assertion.
The new cheap stop watcher saw a stopped job handed to a chat while the retained full admission memo trusted an older floor for 100 ms. Revalidate the shared floor identity before reuse. Keep unchanged document reads at zero and retain all allocation caps.
The new PR-base tool test put codeaf state under its requested workspace, so dev correctly refused the Factory chat before any tool ran. Give the profile its own temporary directory while preserving the real tool call and repair assertions.
The durable journal created batch channels on recording callers, but the shared usage writer could send to them after that caller scope ended. The projection-fsync follow-up exposed fatal synctest sends in dev Memory cases. Start synchronizers from a separately joined writer-owned loop, retain independent batching under stalled projection, and keep all existing assertions and shutdown ceilings.
The new tool decoded its own arguments directly, violating dev’s common argument-decoder law. Reuse decodeToolArguments while preserving its empty-object and bound-checkout checks, existing refusal text, and every assertion. Existing structural and carried tool tests pass, with unchanged 208-byte/4-allocation successful calls.
… owner The journal-scope repair made the process writer own a joined synchronizer. Three dev fixtures still built raw writers and skipped that initialization, panicking at close. Reuse the existing constructor before installing their projection blockers. Keep every assertion, shutdown ceiling, and all 200 by 4 close/flush race iterations; no production source changes.
#2192) #2192 makes `make vet` check the Windows test build. The one-engine test that landed with app/v3 ended its stray child with syscall.Kill, which does not exist on Windows, so the new vet step failed on dev's tree. os.Process.Kill sends the same signal on Unix and builds everywhere. Co-Authored-By: Claude Fable 5.2 <[email protected]>
This was referenced Nov 12, 2026
Merged
AbirAbbas
added a commit
that referenced
this pull request
Nov 12, 2026
* Remove a working-notes file that was committed by mistake NOTES-FIX-2597.md was a scratch record of the #2597 fix round. It was never meant to be tracked: it describes local test runs, not the product. Co-Authored-By: Claude Fable 5.2 <[email protected]> * changes: record the removal of the stray notes file Co-Authored-By: Claude Fable 5.2 <[email protected]> --------- Co-authored-by: Claude Fable 5.2 <[email protected]>
This was referenced Nov 12, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
app/v3landed ondevas one squash (#2561), so the pull requests that were still open againstapp/v3could not simply be re-pointed. This carries the ones that integrate cleanly ontodev, one commit per pull request with its title and number kept, after merging them intoapp/v3itself (where each now shows as merged).Carried (16): #2198, #2469, #2586, #2366, #2192, #2149, #2377, #2463, #2269, #2386, #2358, #2090, #1931, #2387, #2364, #2570.
Held, not in this PR (6), each for a stated reason:
TestAppRelayOutageO1O2O3O4O5fails three of three isolated runs and passes without it. Its expiry refusal conflicts with the automatic same-holder outage recovery.How it was judged
By hand checks of the built binary, not by a fully green suite (the suite has known flaky tests; each red here got one isolated rerun and a run on the base before being called real, flaky or already red, and the lists are in the wave's notes).
Hand checks on the
devbuild with a real model, 20 of 21 passing:codeaf execexits 0 with its edit; the desktop engine's newline-JSON door (create an agent, a real reply, reopen the answered receipt, clean shutdown);devcommit missed the same bar in the same conditions (5.4 s once, 0.56 s once), and on a quiet machine the landing head quit in 0.16–0.7 s (Land app/v3 on dev: one trunk (draft until the hand gates pass) #2561). No latency regression from this wave was established; it is recorded, not waved away.Real failures found by the tests during integration were fixed in small follow-up commits (each named in the commit list) or caused a hold (#2381). No assertion was loosened.
What a person should know before these ship
usage.jsonl.pending-v1.jsonl): usage returns after the journal append, with a sync every 100 ms or 64 rows and on clean close. A power loss can lose the last unsynced batch. Older builds do not replay the sidecar.action_revisionto job envelopes; Spending: daily rollup for date-only spend.report #2269 keeps daily spending rollups in memory (bounded).This branch also merges current
dev(#2595, #2596); the one conflict (the factory worker's start) keeps both changes.🤖 Generated with Claude Code