Skip to content

Carry the open app/v3 pull requests that integrate cleanly onto dev (16 of 22) - #2597

Merged
AbirAbbas merged 46 commits into
devfrom
land/app-v3-open-prs
Nov 11, 2026
Merged

AbirAbbas merged 46 commits into
devfrom
land/app-v3-open-prs

Conversation

@AbirAbbas

Copy link
Copy Markdown
Collaborator

What this is

app/v3 landed on dev as one squash (#2561), so the pull requests that were still open against app/v3 could not simply be re-pointed. This carries the ones that integrate cleanly onto dev, one commit per pull request with its title and number kept, after merging them into app/v3 itself (where each now shows as merged).

Carried (16): #2198, #2469, #2586, #2366, #2192, #2149, #2377, #2463, #2269, #2386, #2358, #2090, #1931, #2387, #2364, #2570.

Held, not in this PR (6), each for a stated reason:

How it was judged

By hand checks of the built binary, not by a fully green suite (the suite has known flaky tests; each red here got one isolated rerun and a run on the base before being called real, flaky or already red, and the lists are in the wave's notes).

Hand checks on the dev build with a real model, 20 of 21 passing:

Real failures found by the tests during integration were fixed in small follow-up commits (each named in the commit list) or caused a hold (#2381). No assertion was loosened.

What a person should know before these ship

This branch also merges current dev (#2595, #2596); the one conflict (the factory worker's start) keeps both changes.

🤖 Generated with Claude Code

AbirAbbas and others added 16 commits November 11, 2026 10:29
One conflict, in the factory worker's start: #2596 made the worker ask what
its machine lacks before every lease poll, and #2570 keeps that word where
lost-runner recovery reads it. Both are kept: each poll's answer is stored.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
…entity

Custody now creates a quiet local profile on first save. Establish the shared fixtures paired premise before that save so Ensure does not preserve an unintended solo marker. Keep every notice, read-count, ownership, and explicit solo assertion.
The new cheap stop watcher saw a stopped job handed to a chat while the retained full admission memo trusted an older floor for 100 ms. Revalidate the shared floor identity before reuse. Keep unchanged document reads at zero and retain all allocation caps.
The new PR-base tool test put codeaf state under its requested workspace, so dev correctly refused the Factory chat before any tool ran. Give the profile its own temporary directory while preserving the real tool call and repair assertions.
The durable journal created batch channels on recording callers, but the shared usage writer could send to them after that caller scope ended. The projection-fsync follow-up exposed fatal synctest sends in dev Memory cases. Start synchronizers from a separately joined writer-owned loop, retain independent batching under stalled projection, and keep all existing assertions and shutdown ceilings.
The new tool decoded its own arguments directly, violating dev’s common argument-decoder law. Reuse decodeToolArguments while preserving its empty-object and bound-checkout checks, existing refusal text, and every assertion. Existing structural and carried tool tests pass, with unchanged 208-byte/4-allocation successful calls.
… owner

The journal-scope repair made the process writer own a joined synchronizer. Three dev fixtures still built raw writers and skipped that initialization, panicking at close. Reuse the existing constructor before installing their projection blockers. Keep every assertion, shutdown ceiling, and all 200 by 4 close/flush race iterations; no production source changes.
#2192)

#2192 makes `make vet` check the Windows test build. The one-engine test
that landed with app/v3 ended its stray child with syscall.Kill, which
does not exist on Windows, so the new vet step failed on dev's tree.
os.Process.Kill sends the same signal on Unix and builds everywhere.

Co-Authored-By: Claude Fable 5.2 <[email protected]>
@AbirAbbas
AbirAbbas merged commit 0c5fd47 into dev Nov 11, 2026
1 check passed
@AbirAbbas
AbirAbbas deleted the land/app-v3-open-prs branch November 11, 2026 20:50
AbirAbbas added a commit that referenced this pull request Nov 12, 2026
* Remove a working-notes file that was committed by mistake

NOTES-FIX-2597.md was a scratch record of the #2597 fix round. It was never
meant to be tracked: it describes local test runs, not the product.

Co-Authored-By: Claude Fable 5.2 <[email protected]>

* changes: record the removal of the stray notes file

Co-Authored-By: Claude Fable 5.2 <[email protected]>

---------

Co-authored-by: Claude Fable 5.2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant