Repository navigation
tui3: a shell line from Home is recorded as a shell line in tests again - #2644
Merged
Merged
Conversation
#2287 added a SubmitBash method to the shared switchAgent test fake. It shadowed fakeAgent.SubmitBash, which records the line in bashSent, so TestUserBashHomeRunsInTheSelectedProject saw the command arrive as a plain send and failed on dev. Removing it restores the shared method, which calls the same Submit and also records the line. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev PR gate on #2287's merge (
473b159d1) failed one test,TestUserBashHomeRunsInTheSelectedProjectininternal/tui3. It fails on dev and passes on the base.The cause is in the tests only. #2287 added a
SubmitBashmethod to the sharedswitchAgentfake inidle_r9_send_test.go. That method shadowedfakeAgent.SubmitBash, which records the line inbashSent. A!command from Home therefore reached the new conversation as a shell line but was never recorded as one.The fix removes that method. The shared
fakeAgent.SubmitBashcalls the sameSubmitand also records the line. No product code changes.Verification
go test -count=1 -run '^(TestUserBash|TestIdleOpen|TestIdleRelease|TestR6_|TestStorage|TestContinueCard|TestFirstEnterWaitsForOwnershipReading|TestSettings|TestSwitch)' ./internal/tui3/passes. That covers the failing test and every test An idle chat on a paired computer can hand its hold to the relay (opt-in idle handoff) #2287 added that usesswitchAgent.touched tui3leg on the merge commit was green, so this was the only failure in that leg.🤖 Generated with Claude Code