Skip to content

tui3: a shell line from Home is recorded as a shell line in tests again #2644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbirAbbas merged 2 commits into from
Nov 14, 2026
Merged

tui3: a shell line from Home is recorded as a shell line in tests again #2644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
480b138
tui3: a shell line from Home is recorded as a shell line in tests again
AbirAbbas Nov 14, 2026
894a330
changes: entry for #2644
AbirAbbas Nov 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/changes/unreleased/2644-home-bash-test-fake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
kind: internal
title: The tui3 test fake records a shell line from Home again, so the dev gate is green after #2287
pr: 2644
surface: [chat]
invalidates: []
---
4 changes: 0 additions & 4 deletions internal/tui3/idle_r9_send_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,10 +332,6 @@ func (a *p9xBashAgent) SubmitBash(_ context.Context, line string) (<-chan sessio
return ch, nil
}

func (a *switchAgent) SubmitBash(ctx context.Context, line string) (<-chan session.Event, error) {
return a.Submit(ctx, line)
}

func TestIdleOpen_P9X1_BashCommandRunsOwnershipCheckAndKeepsWords(t *testing.T) {
t.Run("offline refusal keeps bash line in box and prints one line", func(t *testing.T) {
a, old, source := r8OwnLiveWindow(t, false)
Expand Down
Loading