Repository navigation
JSON arrays in list flags; --url on search commands (1.2.24) - #10
Merged
Merged
Conversation
List flags split their value on every comma, so values that contain a comma themselves – "Chicago, Illinois", "Technology, Information and Internet", "Example Co., Ltd." – silently became separate filters. A list flag that starts with `[` is now read as a JSON array of strings; plain comma lists behave as before. Core rejects people and company searches that carry neither a term nor a custom search URL, yet several help and README examples were filter-only and the search commands had no way to pass a URL. person, navigator person, company and navigator company search now take --url (sent as customSearchUrl), say that --term is required unless --url is given, and stop with a validation error before calling the API when both are missing.
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List flags. Every filter list flag split its value on every comma, so values containing a comma –
Chicago, Illinois,Technology, Information and Internet,Example Co., Ltd.– silently became separate filters. Production shows this for locations and company names from 8 of the 58 users who filtered through the CLI or skills in 90 days. A list flag that starts with[is now read as a JSON array of strings (--locations '["Chicago, Illinois","Denver"]'). Anything else is the old comma split, so existing lists behave exactly as before. Invalid JSON is rejected with a message naming both forms. This covers person/navigator person/company/navigator company search, company and navigator company fetch employee filters, connection list, jobs search filters and preferences, and post search author industries and actor flags (wherename:identifierelements work inside the array).Search without a term. Core rejects people and company searches that carry neither a term nor a custom search URL: 184 such 400s in 35 days. Yet several help and README examples were filter-only, and no search command could pass a URL. person, navigator person, company and navigator company search now take
--url(sent ascustomSearchUrl). Their help says--termis required unless--urlis given, and they exit 5 before calling the API when both are missing. The filter-only examples now carry--term.Version 1.2.24. Checks: typecheck, eslint, build. Probed the parser with the production values, and checked
--helpand the validation exit.