Repository navigation
Conversation
…ot another app's values The installed tests/e2e/project.config.js is the template, and the template carried one sample app's CONFIGURED values: NAV, PROBE_PAGE, two users in ROLES, a 3-act WALKTHROUGH, 14 PAGE_WIREFRAME rows, project widget names in READY_SELECTORS. On a fresh scaffold of a real Mendix 11.8 app, monkey reached 0 of 8 targets and full-app-walkthrough died at its first seed with an OQL error for an entity the app never had. Every CONFIGURED block now ships empty with a FILL ME marker and its shape in a comment. `node project.config.js` marks each empty block and names the instrument it stops. The walkthrough's NOT CONFIGURED message names the blocks to fill; page-audit advice prints a "no exemplar set" placeholder instead of a page; install-tests.sh lists the blocks. Fixture: tests/wave2/test-e2e-config-neutral.sh (master 1/16, branch 16/16). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
… steps The act loop evaluated act.checks before act.steps. The first act has no handoffAssert to navigate for it, so a first act whose step 1 is the nav to its page read every check on the home page and failed them, one line before its own nav passed (field run on a real Mendix 11.8 app: "x raise:widget:dgTasks not visible", then "v raise:Tasks opens"). An act's leading `nav` steps are now its arrival: they run first, then the widget checks, then the remaining steps. A fatal arrival leaves the checks NOT REACHED. Acts that arrive through a handoffAssert are unchanged. Fixture: tests/wave2/test-walkthrough-act-order.sh (master 2/4, branch 4/4). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
…t measured With the template's NAV now empty, a fresh scaffold's monkey signed in, reported "reached 0 of 0 target(s)" and exited 0: exitCode() treated zero targets as a clean run. (0 of N > 0 already exits 2 since #679.) An empty NAV now stops before the browser with a SETUP NOT CONFIGURED line that says how to fill it, and exitCode() returns 2 for zero targets. The old sample NAV is still recognised (config.js TEMPLATE_NAV) for configs installed before the template went empty. Fixture: tests/wave2/test-monkey-template-nav.sh extended (master monkey.js 9/13, branch 13/13). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE-AFTER-FIX — the act-order change flips PASS→FAIL for a handoff act whose
Other configured shapes are unaffected or improve. On the field config live, Monkey runs under verify-module as kind
Generated by Claude Code |
… checks after the assert Independent review: the nav-first arrival applied to every act, so a handoff act that arrives on page X through its handoffAssert and opens its steps with a nav to Y had its X checks read on Y (reproduced live on Mendix 11.8: see:widget:dgSideBar passed on master, failed on the previous head). After a non-empty handoffAssert the checks are read straight away again; leading-nav arrival applies only to acts without one. The template comment says so. Monkey's NOT CONFIGURED line names --skip-monkey for an app with no menu to fuzz. Fixtures: test-walkthrough-act-order.sh gains that case (master 3/5, previous head 4/5, branch 5/5); test-monkey-template-nav.sh asserts --skip-monkey (previous head 12/13, 13/13). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
|
Review: MERGE — re-review at 340afd7. All three earlier fixes are in. A handoff act now reads its checks on the handoffAssert page, even when its steps start with a nav, and this is verified live on Mendix 11.8.
Regression risk:
Correctness:
Context cost: 65,568 → 65,568 / 80,000. The fix commits touch no routed or always-loaded file, so the earlier measurement stands. Generated by Claude Code |
Direct lane
What changed and why (one paragraph): A fresh scaffold's
tests/e2e/project.config.jsis a byte copy ofproject.config.template.js. The template carried one sample app's CONFIGURED values: 8 menu captions, a probe page, two users, a 3-act walkthrough, 14 wireframe rows and that app's widget names inREADY_SELECTORS. On a blank Mendix 11.8 app scaffolded withinit-project.sh, the first runs measured nothing: monkey reached 0 of 8 targets, andfull-app-walkthrough.jsdied at its first seed with an OQL error for an entity the app never had. This PR has three commits:FILL ME, with its shape in a comment.node tests/e2e/project.config.jsmarks each empty block and names the instrument it stops. The walkthrough's NOT CONFIGURED message names the blocks to fill. page-audit advice prints<no exemplar: set exemplars.listPage …>instead of another app's page.install-tests.shlists the blocks. A project's existingproject.config.jsis never rewritten, as before.checksare now read after its leadingnavsteps. Before this fix, a first act that opens its page in step 1 (the template example's own shape) failed every check against the home page. After a non-empty handoffAssert the checks are read straight away, as on master, even when the act's own steps open with a nav elsewhere. The docs say checks describe the act's landing page, so the engine changed, not the docs.SETUP NOT CONFIGURED: NAV …and exits 2. The message names--skip-monkeyfor an app with no menu to fuzz.exitCode()treats 0 targets as not measured. 0 of N>0 was already exit 2 (monkey.js: the sample NAV in project.config.js is never flagged, and a run that reached 0 of N targets still exits 0 with only info rows #679). Without this commit, commit 1 would open a "reached 0 of 0, exit 0" hole.A second PR (
fix/e2e-live-run-followups) carries the design-audit, app-restart and exec findings from the same field run.Impact
project.config.jsis never synced.project.config.template.js,config.js(comment only),monkey.js,full-app-walkthrough.js,page-audit-rules.jsandbin/install-tests.sh(message text). Fixtures that copy the template asproject.config.jswere re-run, all green (list below).config.jsTEMPLATE_NAVis kept so that configs installed earlier are still recognised. No new artifact reads. Independent of the follow-up PR, except that both add lines at the top of## Unreleasedin CHANGELOG.md (trivial conflict for whichever merges second).Time cost: none · 0 s added · can force rework: n · offset: monkey/walkthrough no longer spend a login and a run measuring nothingFixtures, master vs branch
tests/wave2/test-e2e-config-neutral.sh(new)tests/wave2/test-walkthrough-act-order.sh(new; plus the review's handoff-act-opening-with-a-nav case)tests/wave2/test-monkey-template-nav.sh(extended; mastermonkey.jswith the branch template)--skip-monkey)Existing fixtures that target the changed files or copy the template are green on the branch: test-e2e-visible-wait 8/8, test-navto-missing-item ok, test-monkey-left-app 22/22, test-monkey-oracle 14/14, monkey.selftest ok, the 11 test-journey-* fixtures that copy the template (all pass), test-named-controls 37/37, test-oql-rows 15/15, test-otel-capture-until 4/4, test-report-normalize-two-tree 19/19, test-report-seeds-668 9/9. test-verify-module-446 is 21/22 on both master and the branch (V3
playwright rows=1: an environment difference with a global Playwright, not caused by this PR).Field evidence. A blank Mendix 11.8.0 app (
mxcli run --local --db-type hsqldb, Playwright and Chromium, no Docker) was scaffolded withinit-project.shand booted for real, cold boot 195 s. Master @1a56c3a1 and this branch ran against the same running app:SETUP NOT CONFIGURED: NAV … is empty+ how to fill itOQL error: Can't find entity …(the sample app's entity), findings.json writtenNOT CONFIGURED — … Fill the WALKTHROUGH and ROLES blocks, no findings.jsonnode project.config.js, fresh← FILL MEon NAV, PAGE_WIREFRAME, roles, walkthrough✗ raise:widget:dgTasks … not visible,✗ raise:widget:btnNew, then✓ raise:Tasks opens✓ raise:Tasks opens,✓ raise:widget:dgTasks,✓ raise:widget:btnNewchecks: [dgSideBar], step 1 = nav to TopBar)✗ see:widget:dgSideBar … not visible(read on TopBar)✓ see:widget:dgSideBar, then✓ TopBar overview opens firstThe remaining walkthrough fail on both sides is the field config's own single-module pre-flight, which is by design.
install-tests.sh. The walkthrough fixture uses a stubhelpers.js(no browser) around the realconfig.jsand walkthrough. Both layouts: unchanged root discovery, no path logic touched. Platforms: Node only; the one shell change is echo text.check-portability.shdid not complete inside the 300 s budget in this container: NOT RUN to completion.CHANGELOG.mdline per commit, credited to the field run.Review: pending independent review
https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
Generated by Claude Code