Repository navigation
Conversation
…s axe-core e2e-harness-base.md named only Playwright. Followed literally in a container with a global Playwright, `npm i -D playwright` shadowed it with a version whose browser was not downloaded; design-audit then crashed at chromium.launch (exit 1) and wrote nothing, so the previous run's artifacts/design-audit.json stayed in place and read as current. A browser that does not launch is now a FAULT row per rung-7 check (the artifact is rewritten, exit 2), in the app sweep and in the positive controls. Any other crash removes the previous run's artifact and says so, so report-normalize reads design-audit as `fault`. The doc says to probe for a working Playwright before installing one, and to install axe-core. Fixture: tests/wave2/test-design-audit-stale-artifact.sh (master 1/5, branch 6/6), with Playwright's launch message captured verbatim from the field log. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
readCompleteness() matched only `controlbar <name>`, but mxcli writes a data grid's control bar unnamed. On a real DataGrid2 page with New/Edit buttons the guard FAULTed the page correctly (the buttons are unread) while saying "controlbars: none". Unnamed control bars are now listed as "(unnamed, mdlSource line N)"; the verdict is unchanged. Fixture: tests/wave2/test-design-audit-controlbar.sh over a captured `describe --format elk` of the field app's Tasks.Task_Overview (Mendix 11.8.0) — master 4/5, branch 5/5. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
…literal
app-restart.sh logged to ${TMPDIR:-/tmp}/<mpr name>-run-local.log, shared by every project
whose model has the same name (several field apps were all ProbeApp.mpr). The log is now
<project>/.claude/loop/app-restart/run-local.log, beside start.cmd, self-gitignored and created
only when something is written; LOGDIR still overrides.
exec.sh's watch-compat and change-class lines print a statement head with string literals
blanked to '' ("create or modify demo user '' ( Password: '', ..."), which reads as an empty
name. A blanked literal now shows as '…'; the literal itself is still never printed, so a demo
user's password stays masked.
Fixtures: test-app-restart.sh (master 120/123, branch 123/123), test-exec-lock-watch.sh
(master 126/128, branch 128/128).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01HXpQSjXefSNicGGqP4aiSC
Owner
Author
|
Review: MERGE — no blocking findings. A stale design-audit artifact can no longer read as current, and
Regression risk:
Correctness:
Live, Mendix 11.8, base vs head:
Context cost: 65,568 → 65,568 / 80,000, measured. Generated by Claude Code |
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct lane
What changed and why (one paragraph): These are the follow-up findings from the same field run as the "e2e harness: works out of the box on a fresh scaffold" PR: a real Mendix 11.8 app under
mxcli run --local. This PR has three commits:skills/e2e-harness-base.mdnamed only Playwright. Followed literally in a container with a global Playwright,npm i -D playwrightshadowed the global copy with a version whose browser was not downloaded. design-audit then crashed atchromium.launch(exit 1) and wrote nothing, so the previous run'sdesign-audit.jsonstayed in place and read as current. Now a browser that does not launch gives a FAULT row per rung-7 check, in both the app sweep and the positive controls; the artifact is rewritten and the exit code is 2. Any other crash removes the previous artifact and says so, so report-normalize readsfault. The doc now says to probe for a working Playwright before installing one, and tonpm i -D axe-core.controlbar <name>. mxcli writescontrolbar {with no name, so the page FAULTed correctly but the message said "controlbars: none". The verdict is unchanged.app-restart.shlog moves from${TMPDIR:-/tmp}/<mpr name>-run-local.logto<project>/.claude/loop/app-restart/run-local.log. The old path was shared by every model with the same name. The new file is self-gitignored and created only when written;LOGDIRstill overrides. In exec.sh's watch-compat and change-class lines, a blanked string literal now reads'…'instead of''. Before,create or modify demo user '' ( Password: '', …read as an empty user name. Literals are still never printed, so passwords stay masked.Impact
project-bin/exec.sh: display-onlyshown()added to the shared awk lexer; the''used by the watch classifier's regex is untouched.project-bin/app-restart.sh: the log path changes;test-stack-up.shstill writes its own${LOGDIR:-$TMPDIR}/<project>-run-local.log(not changed here).design-audit.js,skills/e2e-harness-base.md(on-demand). No new artifact reads. Independent of the fresh-scaffold PR, except that both add lines at the top of## Unreleasedin CHANGELOG.md.e2e-harness-base.mdis on-demand.render-routing.sh --checkgives baseline 65,568 / 80,000 on both base and head.Time cost: none · 0 s · can force rework: n · offset: maintainer OKFixtures, master vs branch
tests/wave2/test-design-audit-stale-artifact.sh(new; Playwright's launch message verbatim from the field log)tests/wave2/test-design-audit-controlbar.sh(new; captureddescribe --format elkof the field page)tests/wave2/test-app-restart.sh(extended)tests/wave2/test-exec-lock-watch.sh(extended)Existing fixtures for the changed files are green on the branch: test-design-audit-a11y-evidence 9/9, test-design-audit-css-corpus 7/7, test-design-audit-nav-map 26/26, test-exec-change-class 21/21, test-module-close-cadence 67/67.
Field evidence. A blank Mendix 11.8.0 app was scaffolded with
init-project.shand booted withmxcli run --local --db-type hsqldb(no Docker). Master @1a56c3a1 and this branch ran against the same running app:--page <overview page>, then the same withPLAYWRIGHT_BROWSERS_PATH=/nonexistentdesign-audit crashed: browserType.launch: Executable doesn't exist …, exit 1; artifact md5 unchanged (6fdc6ce6a2b5 → 6fdc6ce6a2b5)INSTRUMENT FAULT (12); artifact rewritten (778ea70cb93a → 116d2107a3b5); a11y/overflow/structure rows arefault — browser did not launch: …controlbars: nonecontrolbars: (unnamed, mdlSource line 4)bin/app-restart.sh(LOGDIR unset)✓ started (log: $TMPDIR/ProbeApp-run-local.log), 59 s✓ started (log: <project>/.claude/loop/app-restart/run-local.log), 75 s; nothing written to$TMPDIRexec.sh --watch-compaton the app's demo-user scriptcreate or modify demo user '' ( Password: '', Enti...create or modify demo user '…' ( Password: '…', Enti...; the password appears in neither outputREC_DIRandnearRootroots. Platforms: plain awk (gsubwith a string pattern; checked on mawk),mkdir -ponly.check-portability.shdid not complete inside the 300 s budget in this container: NOT RUN to completion.CHANGELOG.mdline per commit, credited to the field run.Review: pending independent review
Generated by Claude Code