Skip to content

Interpolate values in epoch and NEST error messages - #1972

Open
evadiva3 wants to merge 2 commits into
NeuralEnsemble:masterfrom
evadiva3:fix/neo-1-missing-f-string-prefixes
Open

evadiva3 wants to merge 2 commits into
NeuralEnsemble:masterfrom
evadiva3:fix/neo-1-missing-f-string-prefixes

Conversation

@evadiva3

Copy link
Copy Markdown

Three error messages print literal {name} (add_epoch, NEST reader ×2)

This fixes the missing interpolation in add_epoch and two NEST reader errors. Regressions cover negative durations, repeated column selections, and unequal sampling distances using synthetic inputs.

python -m pytest neo/test/utils/test_misc.py neo/test/iotest/test_nestio.py -q: 12 passed, 65 skipped. The regression fails without the fix. The 65 NEST dataset tests skip without external recordings; the new message tests use synthetic data and pass. Flake8 still reports existing findings on the unchanged base; this change adds no new findings.

AI assistance: GPT-6.1 Sol via OpenAI Codex helped review and prepare the changes and regression tests, run checks, and prepare this description.

@zm711 zm711 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evadiva3 this looks great. Just delete the test. We don't need a regression test for missing f-strings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants