Repository navigation
rc.4: deprecate the members that have a better route ([Obsolete] warnings) - #118
Merged
Merged
Conversation
…adAsync, the SqlClient package and two small members Each [Obsolete] names its replacement and ends with Removed in 12. The docs table lists them. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
… call the old members Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
…remarks block on To<T> Co-Authored-By: Claude Opus 5.5 <[email protected]>
…s row no longer says a null map is refused Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rc.4 deprecations (API shape): members with a better route get
[Obsolete]as a warning, never an error. Every message names the exact replacement, never points at another obsolete member, and ends "Removed in 12." like the existing ones.Merge after #117. Several messages name
reader.Map(...)andcommand.Map(...), which #117 adds. They are named in plain text only (nocref), so this branch builds on its own.Marked
IDataReaderToList/ToArray/ToImmutableArray(transform)and the sync-transformDbDataReader.ToListAsync(transform)→reader.Map(transform).ToList()and its siblings (ToListAsync(cancellationToken)for the async one).SelectandSelectAsyncstay, and so does theValueTask-transformToListAsync.IExecuteReaderToList/ToArray/ToImmutableArray(transform, behavior)andIterateReader<TEntity, TResult>→.Map(transform).ToList()/.Map(transform).Read(selector); for a non-defaultCommandBehavior, theExecuteReader(handler, behavior)form. TheIDbCommandIterateReaderoverloads stay.DbCommandsync-transformToListAsync→command.Map(transform).ToListAsync(cancellationToken); for aCommandBehavior(oruseReadAsync: false), theExecuteReaderAsync(handler, behavior, cancellationToken)form.To<T>(DataTable, map, clearSourceTable),Transformer<T>.Results(DataTable, bool)and the rewrittenResultsFromDataTablemessage →table.CreateDataReader().Map(map).ToList(), then clear the table yourself.MappedQueryExtensions.ReadAsync→ the token-lastReadAsync(handler, cancellationToken).AddParameterType(this IDbCommand, string, SqlDbType)in both SQL packages →AddParameterTypeon theSqlCommand.ExpressiveCommandBase.Concat<T>→remaining is null ? [first] : remaining.Prepend(first).Not marked in this PR (kept for now): items 15, 18 and 19 of the rc.4 list.
Library
#pragmawith a one-line reason; the rest now calls the non-obsolete implementation.PublicAPIfiles are unchanged (an[Obsolete]attribute does not change the API lines).Docs and tests
ResultsFromDataTableand one test replacement still useTo<T>(DataTable)(under a pragma), becausereader.Mapis not on this branch yet. They move toCreateDataReader().Map(map).ToList()then.Checks
🤖 Generated with Claude Code