Repository navigation
chore: reset migration versions to 0 and drop old compatibility code - #9623
Conversation
Every protocol (syft, syft-job, syft-dataset) and every versioned object goes back to version 0. Older versions, migrations, layouts, release artifacts and fixtures are removed, along with compatibility code for releases up to 0.10.1. Older clients are refused with a clear reason, and a login on an old SyftBox offers a fresh start. The migration framework, protocol negotiation and the release-fixture tooling stay, ready for the next version. Co-Authored-By: Claude Opus 5.5 <[email protected]>
The two test accounts are shared with every other run, including runs of other releases. A SyftBox that an unsupported release wrote now stops the login with an offer to start fresh, so the login tests remove both accounts' SyftBoxes first, as the sync tests already do. Co-Authored-By: Claude Opus 5.5 <[email protected]>
pjwerneck
left a comment
There was a problem hiding this comment.
@rasswanth-s There's a blocker here. Protocol v0 must stay open and the only protocol until we have a real 1.0.0 release, but the next package release is going to freeze protocol v0 and bump to 1, even if it's <1.0.0.
You have to modify the three export_release_artifact.py scripts so they are disabled and do nothing for now. We can also just delete them and restore later, when we decide to really freeze protocol v0 for a 1.0.0 version. Your call. Just make sure docs/release.md has a warning on that.
@koenvanderveen Agreed?
The next release would have frozen protocol 0, so any later change to a version-0 object would need protocol 1, long before 1.0.0. Until the team freezes protocol 0 for 1.0.0, a release freezes nothing: - remove the three export_release_artifact.py scripts, the "Freeze release artifacts" step of the three release workflows, and the export-release-artifacts recipe; a script that did nothing would still fail the release at its git add, as the history folders no longer exist - docs/release.md warns that nothing is frozen before 1.0.0 and says how to restore the scripts from git history; the manual release-fixture step waits for 1.0.0 as well Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
@pjwerneck Thanks, agreed. Fixed in 154e2f2.
|
pjwerneck
left a comment
There was a problem hiding this comment.
@rasswanth-s The blocker is solved, so I'm approving. I recommend doing a pass with the new CLAUDE.md and dev-guidelines before merging.
- DatasetConfigV0 keeps its own folder method names. Folding V1 into V0 had brought V1's names, including the misspelled private_all_datatset_folder(). - When the DO restores its own collections on connect, a collection in a layout this client does not read is now skipped with a warning, as the DS side already does, instead of silently. An owner upgrading from 0.10.1 now sees why a dataset is missing. - unsupported_peer_reason() imports SYFT_VERSION at the top; there is no circular import. - Restore the three syft-job codec guards (unique codec versions, every codec registered in JobStorage, every protocol covered once). Deleting the file with the old-layout tests had removed them too. - The two login handlers share _delete_all_state() instead of a copied delete block. - Test names drop articles and padding words, per dev-guidelines/guidelines.md. The fake Drive download helper is _download_file_returning(). - The two login tests move from test_unsupported_peer.py to test_login_unsupported_state.py; the version file they share moves to tests/unit/utils.py. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Summary
Resets the migration system to a clean start. Every protocol and versioned object in
syft,syft-jobandsyft-datasetis back at version0, and the code that kept older releases (up to 0.10.1) working is removed. Older clients are refused with a clear message.Changes
v0/, and dataset collections use thev0variant.MIN_SUPPORTED_SYFT_VERSIONis0.10.2.requests/back-fill, '@' job names,skip_job_namesand other deprecated options (full list inCHANGELOG.md).export_release_artifact.pyscripts and their release-workflow steps are removed until then, anddocs/release.mdwarns about it and says how to restore them.syft-migrationframework, protocol negotiation, and the release-fixture generators for use from 1.0.0.Testing
syft-rdstest_dataset_only_mock_data_uploaded, also fails ondev.actionlintis clean on the three release workflows without the freeze step.build/folder in a source checkout still holds the old history files and breaks local job runs. Remove it withrm -rf build.Asana task