Repository navigation
Conversation
Co-authored-by: Codex <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
algorithm_processingat app completion in both trees. rads now emitscompute-completedright afterdocker run, before the subject-access POST, matching secure-radsdc-app-completed.subject_accessphase: app completion to a newsubject-access-completedevent. Both trees emit it after their DSAR POSTs.output_handoffphase for secure-rads:subject-access-completedto a new host-reportedoutput-receivedevent, emitted when the vsock output listener sees EOF.result_deliverynow runsoutput-receivedtoresult-persisted. rads runssubject-access-completedtoresult-persisted.nitro-cli describe-enclavespoll beforefinish. The host already waits for the vsock stream to close; instance termination tears the enclave down.why
Closes #116
Closes #117
Before this, secure-rads excluded the enclave subject-access POSTs and the vsock handoff from every phase, and rads charged subject access to
algorithm_processing, so neither the processing nor delivery numbers were comparable. The 1sdescribe-enclavespoll also added enclave teardown to secure-rads delivery.verification
go build ./...inpackages/go-commonandsecure/sce-unit.python3 -c "ast.parse(...)"on the edited exporter and plot modules.node_modulesin either telemetry-service checkout.platform notes
output-receivedis posted by the secure-rads EC2 host;subject-access-completedis posted by the host on rads and by the enclave on secure-rads.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.