Skip to content

fix(benchmark): align processing and delivery phase boundaries - #119

Closed
prdai wants to merge 1 commit into
mainfrom
fix/resolve-issues-116-117
Closed

prdai wants to merge 1 commit into
mainfrom
fix/resolve-issues-116-117

Conversation

@prdai

@prdai prdai commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

what changed

  • End algorithm_processing at app completion in both trees. rads now emits compute-completed right after docker run, before the subject-access POST, matching secure-rads dc-app-completed.
  • Add a subject_access phase: app completion to a new subject-access-completed event. Both trees emit it after their DSAR POSTs.
  • Add a output_handoff phase for secure-rads: subject-access-completed to a new host-reported output-received event, emitted when the vsock output listener sees EOF.
  • Secure-rads result_delivery now runs output-received to result-persisted. rads runs subject-access-completed to result-persisted.
  • Remove the nitro-cli describe-enclaves poll before finish. The host already waits for the vsock stream to close; instance termination tears the enclave down.
  • Add the new events to both telemetry allowlists, the exporter timestamp columns, plots, and the event docs.

why

Closes #116
Closes #117

Before this, secure-rads excluded the enclave subject-access POSTs and the vsock handoff from every phase, and rads charged subject access to algorithm_processing, so neither the processing nor delivery numbers were comparable. The 1s describe-enclaves poll also added enclave teardown to secure-rads delivery.

verification

  • go build ./... in packages/go-common and secure/sce-unit.
  • python3 -c "ast.parse(...)" on the edited exporter and plot modules.
  • TypeScript typecheck and biome not run: no node_modules in either telemetry-service checkout.
  • No benchmark sweep was run. The committed results predate the new events, so re-exporting them leaves the new phases blank. Deploy the services, rebuild the EIF, and run a fresh sweep to populate them.

platform notes

output-received is posted by the secure-rads EC2 host; subject-access-completed is posted by the host on rads and by the enclave on secure-rads.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align result delivery phase and account for secure-rads post-app gap Align algorithm processing phase boundaries between rads and secure-rads

1 participant