Repository navigation
fix(telemetry,log): reject duplicate run events - #123
Merged
Merged
Conversation
Co-authored-by: Codex <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
telemetry-service(secure/andrads/):POST /eventsreturns409when the run already has that event name, instead of enqueuing another row.log-service(secure/andrads/):POST /subject-accessreturns409when any data subject in the batch already has a row for that(algorithmId, runId), instead of appending under a new timestamp.why
Duplicate writes currently append rows because the sort keys include the producer timestamp. A resumed or retried run can therefore record the same phase twice, and a subject-access retry can duplicate a data subject across timestamps.
verification
bun run typecheckandbun run lintpass insecure/telemetry-service,rads/telemetry-service, andrads/log-service.secure/log-servicelint passes. Typecheck fails on the pre-existingCannot find module 'jose'error frompackages/common/src/jwt.tsin this checkout; it passes when the service dependency is linked.notes
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.