Repository navigation
Conversation
Co-authored-by: Codex <[email protected]>
Co-authored-by: Codex <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
proto/sce/v1with theDataAccessservice (FetchRecordsstream,SubmitResult) and theRecordEnvelopeused at rest.RecordEnvelope(google.protobuf.Structpayload, AES-256-GCM) in a DynamoDB Binary instead of base64 JSON.records.json/result.jsonhandoff with a gRPC server on/data/sce.sock; the DC app now pulls records and submits one result Struct, which sce-unit converts back to JSON for the vsock host.SCE_RPC_SOCKET/ALGORITHM_IDinstead of the file paths.why
Issue #21: the sce-unit to DC app contract was a file handoff. This makes it a real protobuf gRPC contract over the same unix socket, shrinks the encrypted record on disk, and makes record access pull-based.
Closes #21.
verification
go build ./...insecure/sce-unit,secure/samples/spend-analysis-go, andsecure/csav/registry-service.cargo buildandcargo fmt --checkinsecure/samples/audience-segments-rust.uv run python -c 'import main'in both Python samples;npx tsc --noEmitinseeding.RecordEnvelope; sce-unitdecryptRecorddecrypted it and theStructround-tripped to the same JSON.node --check main.jsand a generated-stub import inproduct-trends-node.notes
make seed) and rebuilding the sample EIFs: the stored record format and the app contract both changed.secure/samples/audience-segments-rust/target/is now gitignored.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.