Repository navigation
Optimize subscription acknowledgement and WAL prefetching - #18845
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18845 +/- ##
============================================
- Coverage 49.30% 49.28% -0.03%
Complexity 717 717
============================================
Files 5648 5648
Lines 417020 417173 +153
Branches 55108 55145 +37
============================================
- Hits 205608 205598 -10
- Misses 211412 211575 +163 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…l-prefetch-hotspots # Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java
|
Self-review passed. I fixed V2 WAL metadata deserialization preallocation and corrected ACK cleanup ordering so event cleanup follows the in-flight map lock order, while the potentially slow WAL retention refresh remains outside the map callback. Targeted tests passed: ConsensusPrefetchingQueueTest (53) and WALMetaDataV3CompatibilityTest (6). |
Review Summary
|
…r-sync-20261119 # Conflicts: # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java
|
Master sync and validation update
|
|




Summary
inFlightEvents.computecallback. Remove the exact event only after a successful commit so a failed commit remains retryable.Validation
Frontier microbenchmark
A standalone JVM microbenchmark compared rebuilding the writer frontier for each update with incremental priority-queue updates. It ran 20,000 frontier selection/update operations per round, with 3 warm-up rounds and 7 measured rounds; values below are median ns/op (Windows 11, JDK 17.0.15, Intel Core i9-13900H).
This measures frontier bookkeeping only; it is not end-to-end subscription throughput. Full cluster performance measurements were not rerun.