Skip to content

Optimize subscription acknowledgement and WAL prefetching - #18845

Merged
jt2594838 merged 6 commits into
masterfrom
fix/subscription-wal-prefetch-hotspots
Nov 20, 2026
Merged

jt2594838 merged 6 commits into
masterfrom
fix/subscription-wal-prefetch-hotspots

Merge remote-tracking branch 'origin/master' into codex/pr18845-maste…

49a933f
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 19, 2026 in 4m 31s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 3959 in iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '2,747'.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHzVapIim41fv0v1vJf&open=AaHzVapIim41fv0v1vJf&pullRequest=18845

Check warning on line 3966 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/TypeServices.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 14, expected level should be 10.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1WqqAoMpLQXAwzD&open=AaHyy1WqqAoMpLQXAwzD&pullRequest=18845

Check warning on line 1029 in iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add 'since' and/or 'forRemoval' arguments to the @Deprecated annotation.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHzVamaim41fv0v1vJZ&open=AaHzVamaim41fv0v1vJZ&pullRequest=18845

Check warning on line 3967 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/TypeServices.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 14, expected level should be 10.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1WqqAoMpLQXAwzE&open=AaHyy1WqqAoMpLQXAwzE&pullRequest=18845

Check warning on line 3985 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/TypeServices.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 14, expected level should be 10.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1WqqAoMpLQXAwzJ&open=AaHyy1WqqAoMpLQXAwzJ&pullRequest=18845

Check warning on line 4059 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to use the more specialised Functional Interface 'IntFunction<T>'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1Y1qAoMpLQXAwzO&open=AaHyy1Y1qAoMpLQXAwzO&pullRequest=18845

Check warning on line 110 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/statemachine/ConfigRegionStateMachine.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Single-line Javadoc comment should be multi-line.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1h2qAoMpLQXAwzS&open=AaHyy1h2qAoMpLQXAwzS&pullRequest=18845

Check warning on line 272 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/airgap/IoTDBAirGapReceiverAgent.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 198).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1UFqAoMpLQXAwzB&open=AaHyy1UFqAoMpLQXAwzB&pullRequest=18845

Check warning on line 129 in iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/WriterSafeFrontierTracker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use an "AtomicLong" for this field; its operations are atomic.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1kWqAoMpLQXAwzV&open=AaHyy1kWqAoMpLQXAwzV&pullRequest=18845

Check failure on line 4486 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2b1opp2EifT74Js&open=AaFnF2b1opp2EifT74Js&pullRequest=18845

Check warning on line 1001 in iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof Session session'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHzVamaim41fv0v1vJY&open=AaHzVamaim41fv0v1vJY&pullRequest=18845

Check warning on line 441 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/source/PipeConfigTreePrivilegeParseVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1iGqAoMpLQXAwzT&open=AaHyy1iGqAoMpLQXAwzT&pullRequest=18845

Check warning on line 3798 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"event" is a method parameter, and should not be used for synchronization.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2b1opp2EifT74Jp&open=AaFnF2b1opp2EifT74Jp&pullRequest=18845

Check failure on line 1500 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1Y1qAoMpLQXAwzN&open=AaHyy1Y1qAoMpLQXAwzN&pullRequest=18845

Check warning on line 3972 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/TypeServices.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 14, expected level should be 10.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1WqqAoMpLQXAwzH&open=AaHyy1WqqAoMpLQXAwzH&pullRequest=18845

Check warning on line 6055 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '1,543'.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1Y1qAoMpLQXAwzP&open=AaHyy1Y1qAoMpLQXAwzP&pullRequest=18845

Check warning on line 118 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/runtime/PipeSchemaRegionListenerManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '103'.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1P5qAoMpLQXAwy-&open=AaHyy1P5qAoMpLQXAwy-&pullRequest=18845

Check warning on line 3987 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/TypeServices.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'switch rcurly' has incorrect indentation level 12, expected level should be 8.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1WqqAoMpLQXAwzK&open=AaHyy1WqqAoMpLQXAwzK&pullRequest=18845

Check warning on line 176 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/payload/evolvable/request/PipeTransferTabletRawReqV2.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1SYqAoMpLQXAwy_&open=AaHyy1SYqAoMpLQXAwy_&pullRequest=18845

Check warning on line 3980 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/TypeServices.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'case' child has incorrect indentation level 14, expected level should be 10.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1WqqAoMpLQXAwzI&open=AaHyy1WqqAoMpLQXAwzI&pullRequest=18845

Check warning on line 1026 in iotdb-client/session/src/main/java/org/apache/iotdb/session/pool/SessionPool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Summary javadoc is missing.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHzVamaim41fv0v1vJb&open=AaHzVamaim41fv0v1vJb&pullRequest=18845

Check warning on line 6055 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused private "isWriterRuntimeActive" method.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHzVX3Fim41fv0v1vJX&open=AaHzVX3Fim41fv0v1vJX&pullRequest=18845

Check warning on line 281 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/source/IoTDBConfigRegionSource.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1jBqAoMpLQXAwzU&open=AaHyy1jBqAoMpLQXAwzU&pullRequest=18845

Check failure on line 1566 in iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 24 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHzVapIim41fv0v1vJd&open=AaHzVapIim41fv0v1vJd&pullRequest=18845

Check warning on line 221 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/payload/evolvable/batch/PipeTabletEventPlainBatch.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaHyy1SzqAoMpLQXAwzA&open=AaHyy1SzqAoMpLQXAwzA&pullRequest=18845