Repository navigation
fix: stop the workflows from generating Xtend inferrer stubs - #1644
Open
joaodinissf wants to merge 1 commit into
Open
joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
The JVM model inferrers of the Check, Check Configuration, Export, Expression, Format and Scope languages are Java classes now, but the Xbase generator fragment still defaulted to generateXtendInferrer, so every regeneration wrote an .xtend inferrer stub next to the Java one. Set generateXtendInferrer = false in each workflow. The flag also drops the bindIJvmModelInferrer binding from the generated runtime modules, so each hand-written runtime module now binds its inferrer explicitly. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops the MWE2 workflows from writing an
.xtendJVM model inferrer stub next to the Java inferrers of the Check, Check Configuration, Export, Expression, Format and Scope languages.The change
generateXtendInferrer = falseon the Xbase generator fragment inCommonXbase.mwe2(Check and Check Configuration),GenerateExport.mwe2,GenerateExpression.mwe2andGenerateScope.mwe2.GenerateFormat.mwe2usesStandardLanguage, so the flag goes in itsxbaseSupportblock.XbaseGeneratorFragment2from binding the inferrer in the generatedAbstract*RuntimeModule. Each hand-written*RuntimeModulenow has an explicitbindIJvmModelInferrer(), and the generated binding is removed fromsrc-genas the workflows now produce it.checkcfg.core,xtext.export,xtext.expression,xtext.formatandxtext.scopeget a micro version bump.The test language in
check.test.runtimeis not an Xbase language, so its fragment generates nothing and is left unchanged.Testing
.xtendinferrer orxtend-genfolder appears, and the only change in the generated runtime modules is the removed binding.clean verifywithcheckstyle:check,pmd:check,pmd:cpd-checkandspotbugs:checkpasses, including the version baseline check. 490 tests ran with no failures or errors, and 2 were skipped.🤖 Generated with Claude Code