Repository navigation
Conversation
- E2E matrix: 0.88.1 -> 0.89.0-rc.2 - samples/react-native: react-native and @react-native/* to 0.89.0-rc.2 - Drop @react-native/assets-registry from the sample; RN 0.89 ships the asset registry as react-native/asset-registry and no longer publishes it Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
- @react-native-community/cli to 21.0.0 and add @react-native/community-cli-plugin: RN 0.89 no longer ships react-native.config.js, so CLI 20 found no platforms and autolinking failed - Keep @react-native/assets-registry (0.88.1, last published): @react-native-vector-icons imports it directly - MainActivity: drop the removed DefaultNewArchitectureEntryPoint.fabricEnabled - Android build config from the 0.89 template: targetSdk 37, NDK 28.2, Kotlin 2.3.21 - react-native-svg to ^15.16.1 for RN 0.89 JNI support - Patch react-native-image-picker to use the app compileSdkVersion; fbjni 0.8.1 requires compileSdk 36+ Co-Authored-By: Claude Opus 5.5 <[email protected]>
antonis
commented
Nov 19, 2026
antonis
left a comment
Contributor
Author
There was a problem hiding this comment.
Marking as blocked till the final 0.89.0 is released next month
📲 Install BuildsAndroid
|
Contributor
Author
|
Adding some things to recheck: Worth checking: Android touch breadcrumbs
Possible small follow-ups (not 0.89-specific SDK features):
|
4 of 11 tasks
Contributor
Author
|
Rechecked the items above on 1. Android touch breadcrumbs: they work on 0.89.0-rc.2.
2. iOS
3.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Tests the SDK against the React Native
0.89.0-rc.2release candidate.E2E (
e2e-v2.yml): build/test matrix bumped from0.88.1to0.89.0-rc.2(the0.71.19baseline is unchanged).Sample (
samples/react-native):react-nativeand the@react-native/*companions to0.89.0-rc.2.reactstays on19.3.0(satisfies the RN 0.89 peer^19.3.0).@react-native-community/cli*to21.0.0and add@react-native/community-cli-plugin. RN 0.89 no longer shipsreact-native.config.js, so CLI 20 found no platforms and Android autolinking failed. Matches the 0.89 template.MainActivity.kt: dropDefaultNewArchitectureEntryPoint.fabricEnabled, which RN 0.89 removed (New Architecture is always on).targetSdkVersion37, NDK28.2.13676358, Kotlin2.3.21.react-native-svgto^15.16.1: older versions call a JNI overload RN 0.89 deprecated, which fails the-Werrorbuild (fixed upstream in fix(android): support React Native 0.89 JNI calls software-mansion/react-native-svg#3110).react-native-image-pickerso it uses the app'scompileSdkVersioninstead of a hardcoded35. RN 0.89 pulls in fbjni0.8.1, which requires compileSdk 36+. The latest image-picker (8.3.x) still hardcodes 35.@react-native/assets-registrystays at0.88.1(no 0.89 release; RN now shipsreact-native/asset-registry), because@react-native-vector-iconsimports it directly.Reanimated
4.7.1/ Worklets0.13.0stay as they are. They don't list RN 0.89 as supported yet, but their version check skips prerelease RN versions, so the build isn't blocked.💡 Motivation and Context
Part of #7067. Validate the SDK against RN 0.89 before the stable release.
💚 How did you test it?
Locally, on the New Architecture:
assembleDebugsucceeds (Java 17).pod installand a Debug simulator build succeed.react-native bundlefor Android succeeds.The full E2E matrix and sample release builds run on CI via the
ready-to-mergelabel.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
0.89.0stable when it's released, including thereact-native/@react-native/*devDependencies inpackages/core.compileSdkVersion.SceneDelegatesetup from the 0.89 template (the existingAppDelegatesetup still builds).🤖 Generated with Claude Code