Skip to content

[DO NOT MERGE] chore(e2e): Test with React Native 0.89.0-rc.2 - #7071

Draft
antonis wants to merge 3 commits into
mainfrom
antonis/rn-0.89.0-rc.2
Draft

antonis wants to merge 3 commits into
mainfrom
antonis/rn-0.89.0-rc.2

Conversation

@antonis

@antonis antonis commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Tests the SDK against the React Native 0.89.0-rc.2 release candidate.

E2E (e2e-v2.yml): build/test matrix bumped from 0.88.1 to 0.89.0-rc.2 (the 0.71.19 baseline is unchanged).

Sample (samples/react-native):

  • react-native and the @react-native/* companions to 0.89.0-rc.2. react stays on 19.3.0 (satisfies the RN 0.89 peer ^19.3.0).
  • @react-native-community/cli* to 21.0.0 and add @react-native/community-cli-plugin. RN 0.89 no longer ships react-native.config.js, so CLI 20 found no platforms and Android autolinking failed. Matches the 0.89 template.
  • MainActivity.kt: drop DefaultNewArchitectureEntryPoint.fabricEnabled, which RN 0.89 removed (New Architecture is always on).
  • Android build config from the 0.89 template: targetSdkVersion 37, NDK 28.2.13676358, Kotlin 2.3.21.
  • react-native-svg to ^15.16.1: older versions call a JNI overload RN 0.89 deprecated, which fails the -Werror build (fixed upstream in fix(android): support React Native 0.89 JNI calls software-mansion/react-native-svg#3110).
  • Yarn patch for react-native-image-picker so it uses the app's compileSdkVersion instead of a hardcoded 35. RN 0.89 pulls in fbjni 0.8.1, which requires compileSdk 36+. The latest image-picker (8.3.x) still hardcodes 35.
  • @react-native/assets-registry stays at 0.88.1 (no 0.89 release; RN now ships react-native/asset-registry), because @react-native-vector-icons imports it directly.

Reanimated 4.7.1 / Worklets 0.13.0 stay as they are. They don't list RN 0.89 as supported yet, but their version check skips prerelease RN versions, so the build isn't blocked.

💡 Motivation and Context

Part of #7067. Validate the SDK against RN 0.89 before the stable release.

💚 How did you test it?

Locally, on the New Architecture:

  • Android: assembleDebug succeeds (Java 17).
  • iOS: pod install and a Debug simulator build succeed.
  • react-native bundle for Android succeeds.
  • Sample Jest tests and lint pass.

The full E2E matrix and sample release builds run on CI via the ready-to-merge label.

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • No breaking changes.

🔮 Next steps

  • Bump to 0.89.0 stable when it's released, including the react-native/@react-native/* devDependencies in packages/core.
  • Bump Reanimated/Worklets once a release officially supports RN 0.89.
  • Drop the image-picker patch once upstream stops hardcoding compileSdkVersion.
  • Consider moving the sample's iOS app to the SceneDelegate setup from the 0.89 template (the existing AppDelegate setup still builds).
  • Verify the on-demand Android view managers from perf(android): Create SDK view managers on demand #7049 on 0.89 (see the issue comment).

🤖 Generated with Claude Code

- E2E matrix: 0.88.1 -> 0.89.0-rc.2
- samples/react-native: react-native and @react-native/* to 0.89.0-rc.2
- Drop @react-native/assets-registry from the sample; RN 0.89 ships the
  asset registry as react-native/asset-registry and no longer publishes it

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • [DO NOT MERGE] chore(e2e): Test with React Native 0.89.0-rc.2 by antonis and claude in #7071
  • chore(sample): Remove unused Detox setup from the React Native sample by antonis and claude in #7072
  • ci(ios): Build TestFlight sample with Xcode 27 by philprime with sentry-junior in #7065
  • perf(android): Create SDK view managers on demand by alwx in #7049
  • fix(core): Remove web Replay and Feedback from native bundles by default by huextrat, claude and antonis in #7062
  • fix(core): Define UnsafeObject locally instead of deep importing it by alwx in #7061
  • chore(deps): update Android SDK to v8.65.0 by github-actions in #7058

🤖 This preview updates automatically when you update the PR.

@antonis antonis added skip-changelog ready-to-merge Triggers the full CI test suite labels Nov 19, 2026
- @react-native-community/cli to 21.0.0 and add
  @react-native/community-cli-plugin: RN 0.89 no longer ships
  react-native.config.js, so CLI 20 found no platforms and autolinking
  failed
- Keep @react-native/assets-registry (0.88.1, last published):
  @react-native-vector-icons imports it directly
- MainActivity: drop the removed DefaultNewArchitectureEntryPoint.fabricEnabled
- Android build config from the 0.89 template: targetSdk 37, NDK 28.2,
  Kotlin 2.3.21
- react-native-svg to ^15.16.1 for RN 0.89 JNI support
- Patch react-native-image-picker to use the app compileSdkVersion;
  fbjni 0.8.1 requires compileSdk 36+

Co-Authored-By: Claude Opus 5.5 <[email protected]>

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as blocked till the final 0.89.0 is released next month

@sentry

sentry Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Sentry RN io.sentry.reactnative.sample 8.36.0 (116) Release

⚙️ sentry-react-native Build Distribution Settings

@antonis

antonis commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

Adding some things to recheck:

Worth checking: Android touch breadcrumbs

Possible small follow-ups (not 0.89-specific SDK features):

  • iOS SceneDelegate template: new 0.89 apps start React Native from SceneDelegate.swift, not AppDelegate. Our docs and the Sentry wizard (it lives in another repo, so I couldn't check its code here) may still point
    at AppDelegate for native init. RNSentrySDK.start() in didFinishLaunching still runs first, so this is likely only a docs and wizard text update.
  • Global DOMException / structuredClone: RN now exposes these. @sentry/core already formats DOMException errors well, so they get better titles without any change from us.

@antonis

antonis commented Nov 19, 2026

Copy link
Copy Markdown
Contributor Author

Rechecked the items above on 0.89.0-rc.2. Nothing in them needs a change now.

1. Android touch breadcrumbs: they work on 0.89.0-rc.2.

  • Built a release APK of the sample on rc.2 (R8 included), ran it on an emulator and tapped "Set Scope Properties".
  • It recorded a touch breadcrumb with the full component path (Text → … → Button (ErrorsScreen.tsx) → ScrollView (ErrorsScreen.tsx) → …), and there was no "Could not find the touched component" warning.
  • react/react-native@f5feafd4 only changes how Android builds the touch payload. The keys, values and dispatch are the same, and the JS-side target lookup that fix(core): Restore touch breadcrumbs on New Architecture from RN 0.88 #7013 relies on is untouched.

2. iOS SceneDelegate template: nothing to change.

  • Docs: the native-init page (app-start-error-capture.mdx) puts RNSentrySDK.start() in AppDelegate's didFinishLaunching. On the 0.89 template that still runs before React Native starts in SceneDelegate, so the instructions still work.
  • Wizard: the React Native wizard doesn't edit AppDelegate; only the native Apple wizard does.
  • Expo plugin: it inserts RNSentrySDK.start() at the top of didFinishLaunching. Expo's template keeps a multi-line body ending in return super.application(...), including on Expo's main branch, which just added a SceneDelegate. So the insertion compiles.
  • One caveat in the plugin: if an AppDelegate used the bare RN 0.89 one-line body (true), the insertion would make it fail to build (missing return … expected to return 'Bool', confirmed with swiftc). The plugin only runs during Expo prebuild on Expo's own template, so nobody should hit this today. Handling that shape would be optional hardening.

3. DOMException / structuredClone: nothing to do.

  • RN's DOMException extends Error, so the SDK reports it like any other error, with its name (for example AbortError) as the type and its message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked ready-to-merge Triggers the full CI test suite skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant