Repository navigation
Conversation
The retention of Size Analysis and Build Distribution data was read from the quotas backend in five places, each with its own fallback of 90 days for an unlimited retention. They now go through sentry.preprod.retention. The helper also cuts a retention to 396 days. Rows are already deleted at 396 days, and the Objectstore use case configuration for preprod rejects a longer TTL, so an override above that could never be honored. Refs EME-1314
This was referenced Nov 20, 2026
get_retention_days returned None for an unlimited retention, and callers that need a number had a second helper for it. An instance without a configured retention now gets the default of 90 days everywhere, so there is one helper and it always returns a number.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retention of Size Analysis and Build Distribution data is read from the quotas backend in five places, each with its own fallback of 90 days for an unlimited retention. They now read it through
sentry.preprod.retention, which holds that default once and is also where the later PRs in this stack compute an artifact's expiry.The helper cuts a retention to 396 days, in
MAX_RETENTION_DAYS. Retention overrides have no upper bound, but rows are already deleted at 396 days and the Objectstore use case configuration for preprod rejects a longer TTL with a 400, so a longer override could never be honored. The retention endpoint that Launchpad reads for the TTL of app icons now returns at most 396 for the same reason. Launchpad itself needs no change.Refs EME-1314
Cross-repository landing order (top to bottom)
cleanuponce they are past their stamped expiry--daysstill does on the preprod artifacts cleanup cron