Repository navigation
Conversation
cleanup deleted every PreprodArtifact at a fixed age, the --days of the cron that runs it. It now deletes an artifact once it is past the date_expires stamped on it at creation, whatever --days is, like the other models with a per-record expiry. An artifact without a date_expires is still deleted by age. That covers rows that are not backfilled yet and rows created under an unlimited retention, so no row can be left behind forever. The deletion task now also removes the artifact's snapshot objects from Objectstore and its trace items from EAP, as a deletion requested by a user already does. Refs EME-1314
This was referenced Nov 20, 2026
An artifact without an expiry date is now only one that predates the column.
Contributor
Sentry Snapshot Testing
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanupdeletes every preprod artifact at one fixed age, the--daysof the cron that runs it: 396 on the multi-tenant cells and 90 on the single-tenant ones. It now deletes an artifact once it is past thedate_expiresthat was stamped on it at creation.PreprodArtifactjoins the models with a per-record expiry, whichcleanupdeletes whatever--daysis. The cron arguments in ops therefore do not change, and single-tenant cells get the same rule from their genericcleanuprun. On those cells a build is now kept for its retention instead of 90 days, which uses more storage there.Developer plan. Both retentions are 30 days on the Developer plan, which has no Build Distribution, so its builds are now deleted 30 days after the upload instead of after 396 days. The first
cleanuprun after the backfill deletes the existing builds of Developer organizations that are older than 30 days, including builds uploaded on a trial or a paid plan before the organization moved to Developer. How many rows that first run deletes has not been measured.Rows without a date are still deleted by age, at
--days. That covers rows that are not backfilled yet, which on a self-hosted instance is every row created before the upgrade. This is therefore safe to deploy before the backfill has finished, and no row can stay forever.Objectstore and EAP. The deletion task now uses the path that a deletion requested by a user already uses, which also removes the artifact's snapshot objects from Objectstore and its trace items from EAP. This adds one EAP delete request per project to each chunk of 100 artifacts that the hourly cron deletes.
Refs EME-1314
Cross-repository landing order (top to bottom)
cleanuponce they are past their stamped expiry--daysstill does on the preprod artifacts cleanup cron