Repository navigation
fix: keep shell notification and OSD settings private - #1812
Conversation
Reviewer's GuideConfigurationChange the audited internal notification and OSD DConfig keys from public to private while leaving shared public interfaces and all other settings unchanged.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
d445367 to
f5ffc05
Compare
|
f5ffc05 to
4689378
Compare
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本次变更已正确修复配置可见性声明,无需额外修复代码示例。 修正后的配置项示例: "hideDuplicateMode": {
"value": false,
"description": "Hide duplicate mode when switching display modes",
"description[zh_CN]": "配置为 true 时,切换显示模式时不显示复制模式",
"permissions": "readwrite",
"visibility": "private"
}本报告由 AI 代码审查工具自动生成 |
1. Mark 7 audited keys private across 2 DConfig schemas. 2. Preserve shared public interfaces and uninstalled source copies. 3. Keep values, flags, permissions and business logic unchanged. Log: No user-facing changes Influence: 1. Validate that all changed DConfig schemas load without JSON errors. 2. Open display OSD and notifications and verify settings persist. 3. Verify retained public and excluded keys match the audit workbook. fix: 通知和OSD内部配置声明为private 1. 按审查表将2份DConfig定义中的7个属性声明为private。 2. 保留跨应用共享public接口及当前构建不安装的旧定义。 3. 不修改默认值、flags、permissions或业务逻辑。 Influence: 1. 校验所有改动的DConfig JSON可正常解析和加载。 2. 打开显示OSD和通知,确认展示及设置持久化正常。 3. 对照审查表确认保留的public属性和排除项未被修改。 Log: 无用户可见变化 PMS: TASK-398753
4689378 to
8d317a4
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia, xujin177 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
按DConfig审查表收敛dde-shell的内部配置声明:共7个键、2份JSON从public改为private。
public表示提供给其他应用直接访问,private表示应用内部使用。外部通过D-Bus使用功能、只读取同JSON其他属性、同宿主插件或已无有效业务消费的配置,按表内逐键结论处理。
panels/notification/osd/configs/org.deepin.dde.shell.osd.jsonhideDuplicateMode、hideExtendMode、hideSingleModepanels/notification/server/configs/org.deepin.dde.shell.notification.jsonbubbleContentRowCount、maxCount、notificationCleanupDays、notificationClosed保留接口/排除项:shared notification controls and appsInfo。表中判为合理的public以及未安装旧副本均不调整。
仅修改上述JSON的visibility;默认值、serial、flags、permissions、键名和业务逻辑均不变。
这是接口声明收敛,不宣称仅改private已实现运行时访问隔离。
验证:全部改动JSON解析通过;逐键语义差异及逐行diff确认只包含表中visibility变化;
git diff --check通过。运行时回归建议见提交信息Influence;本次未启动或修改运行中的桌面配置。
PMS: TASK-398753
Summary by Sourcery
Enhancements: