Skip to content

fix: keep shell notification and OSD settings private - #1812

Merged
xujin177 merged 2 commits into
linuxdeepin:masterfrom
xujin177:fix/dconfig-public-audit-task-398753
Nov 19, 2026
Merged

xujin177 merged 2 commits into
linuxdeepin:masterfrom
xujin177:fix/dconfig-public-audit-task-398753

Conversation

@xujin177

@xujin177 xujin177 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

按DConfig审查表收敛dde-shell的内部配置声明:共7个键、2份JSON从public改为private。

public表示提供给其他应用直接访问,private表示应用内部使用。外部通过D-Bus使用功能、只读取同JSON其他属性、同宿主插件或已无有效业务消费的配置,按表内逐键结论处理。

JSON(仓库内路径) 本次改为private的键 数量
panels/notification/osd/configs/org.deepin.dde.shell.osd.json hideDuplicateMode、hideExtendMode、hideSingleMode 3
panels/notification/server/configs/org.deepin.dde.shell.notification.json bubbleContentRowCount、maxCount、notificationCleanupDays、notificationClosed 4

保留接口/排除项:shared notification controls and appsInfo。表中判为合理的public以及未安装旧副本均不调整。
仅修改上述JSON的visibility;默认值、serial、flags、permissions、键名和业务逻辑均不变。
这是接口声明收敛,不宣称仅改private已实现运行时访问隔离。

验证:全部改动JSON解析通过;逐键语义差异及逐行diff确认只包含表中visibility变化;git diff --check通过。
运行时回归建议见提交信息Influence;本次未启动或修改运行中的桌面配置。

PMS: TASK-398753

Summary by Sourcery

Enhancements:

  • Restrict seven internal shell notification and OSD configuration keys to private visibility while preserving their existing defaults, permissions, names, and behavior.

@sourcery-ai

sourcery-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Configuration

Change the audited internal notification and OSD DConfig keys from public to private while leaving shared public interfaces and all other settings unchanged.

  • panels/notification/osd/configs/org.deepin.dde.shell.osd.json L14, L25, L36
  • panels/notification/server/configs/org.deepin.dde.shell.notification.json L69-157 (4 small edits)

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@xujin177
xujin177 force-pushed the fix/dconfig-public-audit-task-398753 branch from d445367 to f5ffc05 Compare November 16, 2026 07:06
@deepin-ci-robot

deepin-ci-robot commented Nov 16, 2026 •

Copy link
Copy Markdown

⚠️ OBS CI 构建警告日志 (Commit: 10374fa8)

提示:以下为 OBS CI 构建中 Lintian 检测到的警告信息,默认折叠,点击展开查看详情。完整日志请参阅对应构建状态链接。

deepin_develop / aarch64 (Lintian 警告: 15 条)
[ 1191s] W: dde-shell: desktop-command-not-in-package bin/false [usr/share/applications/org.deepin.dde-shell.desktop]
[ 1191s] N: 
[ 1191s] N:   The desktop entry specifies a Command that does not match any of the
[ 1191s] N:   executables shipped in the package.
[ 1191s] N:   
[ 1191s] N:   This condition is often caused by a typo, or the desktop file was not
[ 1191s] N:   updated after the installed path of the executable was modified.
[ 1191s] N:   
[ 1191s] N:   Packages should ship executables that are used as commands in desktop
[ 1191s] N:   files.
[ 1191s] N: 
[ 1191s] N:   Visibility: warning
[ 1191s] N:   Show-Always: no
[ 1191s] N:   Check: menu-format
[ 1191s] N: 
[ 1191s] N:
[ 1191s] W: dde-shell: link-to-shared-library-in-wrong-package usr/lib/aarch64-linux-gnu/libds-notification-shared.so.2.0.61 [usr/lib/aarch64-linux-gnu/libds-notification-shared.so]
[ 1191s] N: 
[ 1191s] N:   Although this package is not a "-dev" package, it installs a
[ 1191s] N:   "libsomething.so" symbolic link referencing the corresponding shared
[ 1191s] N:   library. When the link doesn't include the version number, it is used by
[ 1191s] N:   the linker when other programs are built against this shared library.
[ 1191s] N:   
[ 1191s] N:   Shared libraries are supposed to place such symbolic links in their
[ 1191s] N:   respective "-dev" packages, so it is a bug to include it with the main
[ 1191s] N:   library package.
[ 1191s] N:   
[ 1191s] N:   However, if this is a small package which includes the runtime and the
[ 1191s] N:   development libraries, this is not a bug. In the latter case, please
[ 1191s] N:   override this warning.
[ 1191s] N: 
[ 1191s] N:   Please refer to Development files (Section 8.4) in the Debian Policy
[ 1191s] N:   Manual for details.
[ 1191s] N: 
[ 1191s] N:   Visibility: warning
[ 1191s] N:   Show-Always: no
[ 1191s] N:   Check: libraries/shared/links
[ 1191s] N:   Renamed from: non-dev-pkg-with-shlib-symlink
[ 1191s] N: 
[ 1191s] N:
[ 1191s] W: dde-shell: no-manual-page [usr/bin/dde-shell]
[ 1191s] N: 
[ 1191s] N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
[ 1191s] N:   a manual page
[ 1191s] N:   
[ 1191s] N:   Note that though the man program has the capability to check for several
[ 1191s] N:   program names in the NAMES section, each of these programs should have its
[ 1191s] N:   own manual page (a symbolic link to the appropriate manual page is
[ 1191s] N:   sufficient) because other manual page viewers such as xman or tkman don't
[ 1191s] N:   support this.
[ 1191s] N:   
[ 1191s] N:   If the name of the manual page differs from the binary by case, man may be
[ 1191s] N:   able to find it anyway; however, it is still best practice to match the
[ 1191s] N:   exact capitalization of the executable in the manual page.
[ 1191s] N:   
[ 1191s] N:   If the manual pages are provided by another package on which this package
[ 1191s] N:   depends, Lintian may not be able to determine that manual pages are
[ 1191s] N:   available. In this case, after confirming that all binaries do have manual
[ 1191s] N:   pages after this package and its dependencies are installed, please add a
[ 1191s] N:   Lintian override.
[ 1191s] N: 
[ 1191s] N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
[ 1191s] N:   for details.
[ 1191s] N: 
[ 1191s] N:   Visibility: warning
[ 1191s] N:   Show-Always: no
[ 1191s] N:   Check: documentation/manual
[ 1191s] N:   Renamed from: binary-without-manpage
[ 1191s] N: 
[ 1191s] N:
[ 1191s] W: dde-shell source: no-nmu-in-changelog [debian/changelog:1]
[ 1191s] N: 
[ 1191s] N:   When you NMU a package, that fact should be mentioned on the first line in
[ 1191s] N:   the changelog entry. Use the words "NMU" or "Non-maintainer upload" (case
[ 1191s] N:   insensitive).
[ 1191s] N:   
[ 1191s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[ 1191s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[ 1191s] N:   identical to the maintainer or one of the uploaders. If this is a local
[ 1191s] N:   package (not intended for Debian), you can suppress this warning by
[ 1191s] N:   putting "local" in the version number or "local package" on the first line
[ 1191s] N:   of the changelog entry.
[ 1191s] N: 
[ 1191s] N:   Please refer to Using the DELAYED/ queue (Section 5.11.3) in the Debian
[ 1191s] N:   Developer's Reference for details.
[ 1191s] N: 
[ 1191s] N:   Visibility: warning
[ 1191s] N:   Show-Always: no
[ 1191s] N:   Check: nmu
[ 1191s] N:   Renamed from: changelog-should-mention-nmu
[ 1191s] N: 
[ 1191s] N:
[ 1191s] W: dde-shell: package-name-doesnt-match-sonames libds-notification-shared2
[ 1191s] N: 
[ 1191s] N:   The package name of a library package should usually reflect the soname of
[ 1191s] N:   the included library. The package name can determined from the library
[ 1191s] N:   file name with the following code snippet:
[ 1191s] N:   
[ 1191s] N:    $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/^[[:space:]]*SONAME[[:space:]]*//p' | \
[ 1191s] N:        sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/'
[ 1191s] N: 
[ 1191s] N:   Visibility: warning
[ 1191s] N:   Show-Always: no
[ 1191s] N:   Check: libraries/shared/soname
[ 1191s] N: 
[ 1191s] N:
[ 1191s] W: libdde-shell: package-name-doesnt-match-sonames libdde-shell1
[ 1191s] N:
[ 1191s] W: libdde-shell-dock: package-name-doesnt-match-sonames libdde-shell-dock1
[ 1191s] N:
[ 1191s] W: dde-shell source: source-nmu-has-incorrect-version-number 2.0.61+u028 [debian/changelog:1]
[ 1191s] N: 
[ 1191s] N:   A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a
[ 1191s] N:   native package). This is to prevent stealing version numbers from the
[ 1191s] N:   maintainer.
[ 1191s] N:   
[ 1191s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[ 1191s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[ 1191s] N:   identical to the maintainer or one of the uploaders. If this is a local
[ 1191s] N:   package (not intended for Debian), you can suppress this warning by
[ 1191s] N:   putting "local" in the version number or "local package" on the first line
[ 1191s] N:   of the changelog entry.
[ 1191s] N: 
[ 1191s] N:   Please refer to NMUs and debian/changelog (Section 5.11.2) in the Debian
[ 1191s] N:   Developer's Reference for details.
[ 1191s] N: 
[ 1191s] N:   Visibility: warning
[ 1191s] N:   Show-Always: no
[ 1191s] N:   Check: nmu
[ 1191s] N: 
[ 1191s] N:
[ 1191s] W: dde-shell: unknown-section DDE
[ 1191s] N: 
[ 1191s] N:   The "Section:" field in this package's control file is not one of the
[ 1191s] N:   sections in use on the ftp archive. Valid sections are currently admin,
[ 1191s] N:   comm, cli-mono, database, debug, devel, doc, editors, electronics,
[ 1191s] N:   embedded, fonts, games, gnome, gnu-r, gnustep, graphics, hamradio,
[ 1191s] N:   haskell, httpd, interpreters, java, javascript, kde, libdevel, libs, lisp,
[ 1191s] N:   localization, kernel, mail, math, misc, net, news, ocaml, oldlibs,
[ 1191s] N:   otherosfs, perl, php, python, ruby, rust, science, shells, sound, tex,
[ 1191s] N:   text, utils, vcs, video, web, x11, xfce, zope.
[ 1191s] N:   
[ 1191s] N:   The section name should be preceded by either "contrib/", "non-free/" or
[ 1191s] N:   "non-free-firmware/" if the package is in the according archive area.
[ 1191s] N: 
[ 1191s] N:   Please refer to Sections (Section 2.4) in the Debian Policy Manual for
[ 1191s] N:   details.
[ 1191s] N: 
[ 1191s] N:   Visibility: warning
[ 1191s] N:   Show-Always: no
[ 1191s] N:   Check: fields/section
[ 1191s] N: 
[ 1191s] N:
[ 1191s] W: dde-shell-example: unknown-section DDE
[ 1191s] N:
[ 1191s] W: libdde-shell: unknown-section DDE
[ 1191s] N:
[ 1191s] W: libdde-shell-dev: unknown-section DDE
[ 1191s] N:
[ 1191s] W: libdde-shell-dock: unknown-section DDE
[ 1191s] N:
[ 1191s] W: libdde-shell-dock-dev: unknown-section DDE
[ 1192s] Warning: mkbaselibs missing in build root, skipping baselibs
deepin_develop / x86_64 (Lintian 警告: 15 条)
[  398s] W: dde-shell: desktop-command-not-in-package bin/false [usr/share/applications/org.deepin.dde-shell.desktop]
[  398s] N: 
[  398s] N:   The desktop entry specifies a Command that does not match any of the
[  398s] N:   executables shipped in the package.
[  398s] N:   
[  398s] N:   This condition is often caused by a typo, or the desktop file was not
[  398s] N:   updated after the installed path of the executable was modified.
[  398s] N:   
[  398s] N:   Packages should ship executables that are used as commands in desktop
[  398s] N:   files.
[  398s] N: 
[  398s] N:   Visibility: warning
[  398s] N:   Show-Always: no
[  398s] N:   Check: menu-format
[  398s] N: 
[  398s] N:
[  398s] W: dde-shell: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-gnu/libds-notification-shared.so.2.0.61 [usr/lib/x86_64-linux-gnu/libds-notification-shared.so]
[  398s] N: 
[  398s] N:   Although this package is not a "-dev" package, it installs a
[  398s] N:   "libsomething.so" symbolic link referencing the corresponding shared
[  398s] N:   library. When the link doesn't include the version number, it is used by
[  398s] N:   the linker when other programs are built against this shared library.
[  398s] N:   
[  398s] N:   Shared libraries are supposed to place such symbolic links in their
[  398s] N:   respective "-dev" packages, so it is a bug to include it with the main
[  398s] N:   library package.
[  398s] N:   
[  398s] N:   However, if this is a small package which includes the runtime and the
[  398s] N:   development libraries, this is not a bug. In the latter case, please
[  398s] N:   override this warning.
[  398s] N: 
[  398s] N:   Please refer to Development files (Section 8.4) in the Debian Policy
[  398s] N:   Manual for details.
[  398s] N: 
[  398s] N:   Visibility: warning
[  398s] N:   Show-Always: no
[  398s] N:   Check: libraries/shared/links
[  398s] N:   Renamed from: non-dev-pkg-with-shlib-symlink
[  398s] N: 
[  398s] N:
[  398s] W: dde-shell: no-manual-page [usr/bin/dde-shell]
[  398s] N: 
[  398s] N:   Each binary in /usr/bin, /usr/sbin, /bin, /sbin or /usr/games should have
[  398s] N:   a manual page
[  398s] N:   
[  398s] N:   Note that though the man program has the capability to check for several
[  398s] N:   program names in the NAMES section, each of these programs should have its
[  398s] N:   own manual page (a symbolic link to the appropriate manual page is
[  398s] N:   sufficient) because other manual page viewers such as xman or tkman don't
[  398s] N:   support this.
[  398s] N:   
[  398s] N:   If the name of the manual page differs from the binary by case, man may be
[  398s] N:   able to find it anyway; however, it is still best practice to match the
[  398s] N:   exact capitalization of the executable in the manual page.
[  398s] N:   
[  398s] N:   If the manual pages are provided by another package on which this package
[  398s] N:   depends, Lintian may not be able to determine that manual pages are
[  398s] N:   available. In this case, after confirming that all binaries do have manual
[  398s] N:   pages after this package and its dependencies are installed, please add a
[  398s] N:   Lintian override.
[  398s] N: 
[  398s] N:   Please refer to Manual pages (Section 12.1) in the Debian Policy Manual
[  398s] N:   for details.
[  398s] N: 
[  398s] N:   Visibility: warning
[  398s] N:   Show-Always: no
[  398s] N:   Check: documentation/manual
[  398s] N:   Renamed from: binary-without-manpage
[  398s] N: 
[  398s] N:
[  398s] W: dde-shell source: no-nmu-in-changelog [debian/changelog:1]
[  398s] N: 
[  398s] N:   When you NMU a package, that fact should be mentioned on the first line in
[  398s] N:   the changelog entry. Use the words "NMU" or "Non-maintainer upload" (case
[  398s] N:   insensitive).
[  398s] N:   
[  398s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  398s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  398s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  398s] N:   package (not intended for Debian), you can suppress this warning by
[  398s] N:   putting "local" in the version number or "local package" on the first line
[  398s] N:   of the changelog entry.
[  398s] N: 
[  398s] N:   Please refer to Using the DELAYED/ queue (Section 5.11.3) in the Debian
[  398s] N:   Developer's Reference for details.
[  398s] N: 
[  398s] N:   Visibility: warning
[  398s] N:   Show-Always: no
[  398s] N:   Check: nmu
[  398s] N:   Renamed from: changelog-should-mention-nmu
[  398s] N: 
[  398s] N:
[  398s] W: dde-shell: package-name-doesnt-match-sonames libds-notification-shared2
[  398s] N: 
[  398s] N:   The package name of a library package should usually reflect the soname of
[  398s] N:   the included library. The package name can determined from the library
[  398s] N:   file name with the following code snippet:
[  398s] N:   
[  398s] N:    $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/^[[:space:]]*SONAME[[:space:]]*//p' | \
[  398s] N:        sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/'
[  398s] N: 
[  398s] N:   Visibility: warning
[  398s] N:   Show-Always: no
[  398s] N:   Check: libraries/shared/soname
[  398s] N: 
[  398s] N:
[  398s] W: libdde-shell: package-name-doesnt-match-sonames libdde-shell1
[  398s] N:
[  398s] W: libdde-shell-dock: package-name-doesnt-match-sonames libdde-shell-dock1
[  398s] N:
[  398s] W: dde-shell source: source-nmu-has-incorrect-version-number 2.0.61+u028 [debian/changelog:1]
[  398s] N: 
[  398s] N:   A source NMU should have a Debian revision of "-x.x" (or "+nmuX" for a
[  398s] N:   native package). This is to prevent stealing version numbers from the
[  398s] N:   maintainer.
[  398s] N:   
[  398s] N:   Maybe you didn't intend this upload to be a NMU, in that case, please
[  398s] N:   double-check that the most recent entry in the changelog is byte-for-byte
[  398s] N:   identical to the maintainer or one of the uploaders. If this is a local
[  398s] N:   package (not intended for Debian), you can suppress this warning by
[  398s] N:   putting "local" in the version number or "local package" on the first line
[  398s] N:   of the changelog entry.
[  398s] N: 
[  398s] N:   Please refer to NMUs and debian/changelog (Section 5.11.2) in the Debian
[  398s] N:   Developer's Reference for details.
[  398s] N: 
[  398s] N:   Visibility: warning
[  398s] N:   Show-Always: no
[  398s] N:   Check: nmu
[  398s] N: 
[  398s] N:
[  398s] W: dde-shell: unknown-section DDE
[  398s] N: 
[  398s] N:   The "Section:" field in this package's control file is not one of the
[  398s] N:   sections in use on the ftp archive. Valid sections are currently admin,
[  398s] N:   comm, cli-mono, database, debug, devel, doc, editors, electronics,
[  398s] N:   embedded, fonts, games, gnome, gnu-r, gnustep, graphics, hamradio,
[  398s] N:   haskell, httpd, interpreters, java, javascript, kde, libdevel, libs, lisp,
[  398s] N:   localization, kernel, mail, math, misc, net, news, ocaml, oldlibs,
[  398s] N:   otherosfs, perl, php, python, ruby, rust, science, shells, sound, tex,
[  398s] N:   text, utils, vcs, video, web, x11, xfce, zope.
[  398s] N:   
[  398s] N:   The section name should be preceded by either "contrib/", "non-free/" or
[  398s] N:   "non-free-firmware/" if the package is in the according archive area.
[  398s] N: 
[  398s] N:   Please refer to Sections (Section 2.4) in the Debian Policy Manual for
[  398s] N:   details.
[  398s] N: 
[  398s] N:   Visibility: warning
[  398s] N:   Show-Always: no
[  398s] N:   Check: fields/section
[  398s] N: 
[  398s] N:
[  398s] W: dde-shell-example: unknown-section DDE
[  398s] N:
[  398s] W: libdde-shell: unknown-section DDE
[  398s] N:
[  398s] W: libdde-shell-dev: unknown-section DDE
[  398s] N:
[  398s] W: libdde-shell-dock: unknown-section DDE
[  398s] N:
[  398s] W: libdde-shell-dock-dev: unknown-section DDE
[  399s] Warning: mkbaselibs missing in build root, skipping baselibs

@xujin177
xujin177 force-pushed the fix/dconfig-public-audit-task-398753 branch from f5ffc05 to 4689378 Compare November 16, 2026 07:57
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交将 DConfig 配置文件中 4 处 visibility 从 public 修正为 private, 修复了配置可见性声明错误。JSON 语法正确,变更一致且清晰,无安全漏洞, OCR 审查与启发式扫描均未发现问题。变更低风险,符合 commit 目的。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例

本次变更已正确修复配置可见性声明,无需额外修复代码示例。 修正后的配置项示例: "hideDuplicateMode": {
  "value": false,
  "description": "Hide duplicate mode when switching display modes",
  "description[zh_CN]": "配置为 true 时,切换显示模式时不显示复制模式",
  "permissions": "readwrite",
  "visibility": "private"
}

本报告由 AI 代码审查工具自动生成

1. Mark 7 audited keys private across 2 DConfig schemas.
2. Preserve shared public interfaces and uninstalled source copies.
3. Keep values, flags, permissions and business logic unchanged.

Log: No user-facing changes

Influence:

1. Validate that all changed DConfig schemas load without JSON errors.
2. Open display OSD and notifications and verify settings persist.
3. Verify retained public and excluded keys match the audit workbook.

fix: 通知和OSD内部配置声明为private

1. 按审查表将2份DConfig定义中的7个属性声明为private。
2. 保留跨应用共享public接口及当前构建不安装的旧定义。
3. 不修改默认值、flags、permissions或业务逻辑。

Influence:

1. 校验所有改动的DConfig JSON可正常解析和加载。
2. 打开显示OSD和通知,确认展示及设置持久化正常。
3. 对照审查表确认保留的public属性和排除项未被修改。

Log: 无用户可见变化
PMS: TASK-398753
@xujin177
xujin177 force-pushed the fix/dconfig-public-audit-task-398753 branch from 4689378 to 8d317a4 Compare November 18, 2026 10:05
@xujin177 xujin177 changed the title fix: correct shell DConfig visibility declarations fix: keep shell notification and OSD settings private Nov 18, 2026
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia, xujin177

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xujin177
xujin177 merged commit 0ba669a into linuxdeepin:master Nov 19, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants