Repository navigation
fix(dock): restore Wayland edge reveal - #1829
Conversation
Reviewer's GuideImplementationRestrict compositor-reported size updates to active dock resizing so delayed animation geometry does not overwrite the saved dock size.
Set Wayland dock visibility from the completed animation direction while leaving the existing X11 visibility paths unchanged.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
TAG Bot TAG: 2.0.62 |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="panels/dock/package/main.qml" line_range="901" />
<code_context>
function onWidthChanged() {
if (dock.useColumnLayout) {
- dock.dockSize = dock.width
Applet.dockSize = dock.width
}
}
</code_context>
<issue_to_address>
**Dock reopens at an unintended size**
When a compositor applies a queued, in-range intermediate resize after the hide/show animation stops, `onFinished` changes `dock.visible`, then the resize handler writes the intermediate `dock.width` to `Applet.dockSize`; `DockPanel::setDockSize` accepts it and `DockSettings` persists it, so the dock reopens at the unintended size.
Prevent compositor-driven intermediate resizes from being written to `Applet.dockSize` after the animation ends.
Also at `panels/dock/package/main.qml:221-224`.
</issue_to_address>d891567 to
5cf01f3
Compare
|
1. Set dock visibility from the completed Wayland animation direction. 2. Save compositor-reported sizes only during an active dock drag. Log: Keep delayed animation sizes out of dock settings. Influence: X11 behavior is unchanged. fix(dock): 修复 Wayland 任务栏边缘唤出 1. 按 Wayland 动画完成时的方向设置任务栏可见性。 2. 仅在拖拽任务栏时保存合成器回报的尺寸。 Log: 避免迟到的动画尺寸写入任务栏设置。 PMS: TASK-398935 Influence: 不改变 X11 行为。
c808d74 to
7c4dabf
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: behind) |
Changes
Verification
PMS: TASK-398935
Summary by Sourcery
Restore Wayland dock edge reveal behavior without changing X11 animation paths.
Bug Fixes:
Enhancements: