Skip to content

fix(otel): mark client span ERROR with tool_error when tools/call returns isError (#3810) - #3831

Closed
thinhnx128 wants to merge 1 commit into
modelcontextprotocol:mainfrom
thinhnx128:fix/otel-client-span-tool-error-3810
Closed

thinhnx128 wants to merge 1 commit into
modelcontextprotocol:mainfrom
thinhnx128:fix/otel-client-span-tool-error-3810

Conversation

@thinhnx128

Copy link
Copy Markdown

Summary

Fixes #3810

Problem

In JSONRPCDispatcher.send_raw_request(), the client OTel span only set StatusCode.ERROR and error.type on a JSON-RPC error response, leaving the client span Unset when tools/call succeeded at the JSON-RPC layer with isError: True (whereas the server span sets error.type="tool_error" and StatusCode.ERROR).

Solution

When method == "tools/call" and the response result has outcome.get("isError") is True, set error.type="tool_error" and StatusCode.ERROR on the client span to match the server span and OTel GenAI MCP conventions.

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Nov 7, 2026
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3810.

If a maintainer assigns you to #3810, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTel client span stays Unset when the tool result has isError: true

1 participant