Repository navigation
fix(otel): mark client span ERROR with tool_error when tools/call returns isError (#3810) - #3831
thinhnx128 wants to merge 1 commit into
Conversation
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3810. If a maintainer assigns you to #3810, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Summary
Fixes #3810
Problem
In
JSONRPCDispatcher.send_raw_request(), the client OTel span only setStatusCode.ERRORanderror.typeon a JSON-RPC error response, leaving the client spanUnsetwhentools/callsucceeded at the JSON-RPC layer withisError: True(whereas the server span setserror.type="tool_error"andStatusCode.ERROR).Solution
When
method == "tools/call"and the response result hasoutcome.get("isError") is True, seterror.type="tool_error"andStatusCode.ERRORon the client span to match the server span and OTel GenAI MCP conventions.