Skip to content

fix(otel): mark client span ERROR with tool_error when tools/call returns isError (#3810) #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thinhnx128 wants to merge 1 commit into from
Closed

fix(otel): mark client span ERROR with tool_error when tools/call returns isError (#3810) #3831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/mcp/shared/jsonrpc_dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,9 @@ async def send_raw_request(
code = str(outcome.code)
span.set_attributes({"error.type": code, "rpc.response.status_code": code})
span.set_status(StatusCode.ERROR, outcome.message)
elif method == "tools/call" and isinstance(outcome, Mapping) and outcome.get("isError") is True:
span.set_attribute("error.type", "tool_error")
span.set_status(StatusCode.ERROR)
except TimeoutError:
if not timeout_armed:
# The clock starts only after the write, so this TimeoutError is the
Expand Down
Loading