Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
Claude finished @adssib's task in 52s —— View job ✅ Ready to merge: a small, additive field on Rules
BugsNone found.
Verified
Non-blocking (optional)
|
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds one field to
plugin.Version:MapsTo plugin.Pin(API,Version), the version of another source a release pins, e.g. an SDK release and the API version it calls (stripe/api2025-03-31). Zero when the release pins nothing or doesn't say.The change feed contract (patch-it
docs/contract/change-feed-api.md, "From and to") now has the server map a package version to what it pins, andGET /v1/plugins/{provider}/{source}/versionsshows it asmaps_to. The server has no table of what an SDK release pins, so the data has to come from the plugin that lists the versions: this is the minimal field for that. No plugin fills it yet; a source that can read it from its releases (the release notes or the version constant in the code) sets it inListVersions, in its own PR.core/plugin/versions.go:Version.MapsTo,Pin,Pin.IsZerodocs/writing-a-plugin.md: how and when to set it (from the release itself, never a hand-kept table)Checklist
git commit -s, DCO)testdata/README.md: not applicableproviders/<provider>-<source>.md: not applicableenv.Get/core/kit/(no fetching added)make checkpasses locallyNotes for the reviewer
Pinis a plain comparable struct, soplugin.Versionstays comparable (kittestcompares it with==).vX.Y.Z) before patch-it's hosted ingestion service can read it: its bump PR then copiesMapsTointo the version rows it stores.🤖 Generated with Claude Code