Repository navigation
Conversation
The classifier reads the SDK changelogs' shapes: release-please's "⚠ BREAKING CHANGES", changesets' "Major Changes", Stripe's⚠️ bullets, "**[BREAKING]**" and "feat!:" marks, an area, issue or commit a bullet starts with, passive removals and renames from an owner, and semantic- release's "# [X.0.0]" major headings. A File can read each GitHub release's notes (Notes), list releases from the repo's tags for an ecosystem with no registry lister, and names a Go module at its major. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
Claude finished @adssib's task in 1m 22s —— View job Rules
Bugs
Verified
Non-blocking
|
| now := env.Now().UTC() | ||
| var events []event.Event | ||
| var rejected []error | ||
| seen := map[string]bool{} // a changelog that lists a bullet twice is one change |
There was a problem hiding this comment.
Chained renames produce replacements that no longer exist. The octokit/rest v18.0.0 notes list both halves of several chains, and each bullet becomes its own event, so the golden tells users to migrate to names that v18 removed:
octokit.issues.replaceLabels→ replacementoctokit.issues.replaceAllLabels, butreplaceAllLabelsis itself "renamed tooctokit.issues.setLabels()"octokit.actions.listWorkflowJobLogs→downloadWorkflowJobLogs, which is itself renamed todownloadJobLogsForWorkflowRunoctokit.reactions.delete→deleteLegacy, which this same release removes ("deprecatedoctokit.reactions.deleteLegacy()has been removed")
A codemod that follows these replacements turns working v17 code into code that breaks on v18. Since you already loop over the release's findings here, one fix is to collect the release's renamed and removed symbols first, then rewrite each Replacement by following the chain to its end (replaceLabels → setLabels). If the chain ends in a removal, drop the replacement (or the event). Please regenerate github-octokit-rest.json afterwards, and add a unit test that covers a two-step chain and a chain that ends in a removal.
A rename whose new name the same release renames again or removes now
points to where the chain ends (or to nothing). A bullet of names alone
is a removal only under a Removed heading, and a change word
("Deprecated:") is never read past as an area.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
7.2.0's events came from bare names under a heading about removed body params: the methods still exist. With names alone read only under a Removed heading, 7.2.0 has no event; 7.1.0's rename is the golden. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
@claude review |
|
Claude finished @adssib's task in 58s —— View job ✅ Ready to merge. Both round 1 fixes are in and pinned by tests, and the reader is stricter than it was. I found no blocking bugs in this round.
Rules
Round 1 fixes, checked
Non-blocking suggestions
I can't run the tests from here. The PR body is right that new exported API ( |
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Combined PR for the stacked changelog work: #227 (reader) → #228 (Stripe) → #229 (Sentry) → #230 (Cloudflare) → #231 (Octokit, ioredis, posthog-go). Same commits; merge this one or the stack.
What this changes
Builds every high and medium
changelog/migrationguidecandidate of the source audit (2026-11-20) that the changelog reader can read with precision. 19 new sources, all versioned (every release from PyPI, npm, the repo's tags or its GitHub releases; no pins), each with a golden on a real consecutive pair and a drop test.stripe/pythonstripe/nodestripe/gostripe/javastripe/rubystripe/dotnetstripe/phpsentry/python-changelogsentry/javascript-changelogsentry/gosentry/dotnetcloudflare/typescriptcloudflare/pythoncloudflare/gocloudflare/terraformgithub/octokit-restgithub/octokit-netredis/ioredisposthog/goReader changes (#227): SDK changelog shapes in the classifier,
Notes(GitHub release notes as the changelog; 12 candidates have only release notes), versions from tags for ecosystems with no registry lister, Go module named at its major.Skipped, and why (precision over recall)
Changelog read, but no bullet in the whole history names a removal plainly (checked over every release section at HEAD; the reader would emit nothing):
openai/python,openai/node,openai/go,openai/java,openai/dotnet(only in betas),openai/agents-python,anthropic/python,anthropic/typescript,anthropic/go,anthropic/java,anthropic/agent-sdk-python,anthropic/agent-sdk-typescript,google/genai-python,google/genai-js,google/genai-go,google/genai-java,google/aiplatform-python,algolia/python,algolia/js,algolia/instantsearch,appwrite/node,appwrite/python,appwrite/web,appwrite/cli,cloudflare/wrangler,convex/js,datadog/api-client-python,datadog/api-client-go,datadog/ddtrace-rb,datadog/terraform,elastic/go,elastic/terraform,flagsmith/python,flagsmith/js,flagsmith/nodejs,mongodb/node-changelog,mongodb/terraform,neon/serverless,neon/terraform(only in betas),newrelic/go-agent,newrelic/ruby-agent,newrelic/terraform,posthog/python,posthog/js,posthog/node,redis/go-redis,salesforce/cli,sentry/java,sentry/php,sentry/cli,supabase/js,supabase/python,vercel/ai-sdk,vercel/cli. Their breaking notes are prose ("breaking change to Decisions types", "Default API version is now v1", "Remove deprecated Projects endpoints") or name parameters, options and behavior.Changelog the reader can't place at a release's tag:
datadog/ddtrace-python(CHANGELOG.md is written on main after the release: the file at the release tag has no section for it),datadog/agent,mongodb/pymongo-changelog,newrelic/node-agent,newrelic/java-agent,redis/lettuce,redis/redis-rb(headings in shapes the reader doesn't parse, or a file with only the current release).GitHub release notes, read with the new reader, no plain removal:
redis/redis-py,github/octokit-js,github/terraform,datadog/ddtrace-java,redis/jedis,mongodb/go,mongodb/csharp,planetscale/database-js,vercel/sdk,supabase/cli.Needs a reader that doesn't exist (fewer than 5 share it): docs release-notes pages
elastic/python,elastic/java,stripe/api-changelog; GitLab-hostedgitlab/client-go,gitlab/terraform; RSS item per releasenewrelic/python-agent-notes(3 candidates).Migration guides — none built:
sentry/python(its 2.0 Removed/Deprecated lists are the CHANGELOG 2.0.0 section's:sentry/python-changelogalready emits them; a second source would duplicate events under another id);sentry/javascript,datadog/ddtrace-js,datadog/ddtrace-go,datadog/datadog-ci,redis/node-redis,cloudflare/terraform-upgrade(prose sections about options, env vars and behavior; a heading reader found 0–2 symbols each);openai/node-migration(a generic reader emits false positives: "Removed request options overloads" lists methods that still exist);anthropic/typescript-migration(the file is a stub);supabase/flutter(pubis not a registry ecosystem; prose); HTML guides with no reader:algolia/python-upgrade,algolia/js-upgrade,mongodb/pymongo,mongodb/node,mongodb/server-compat,elastic/elasticsearch-breaking,elastic/js,vercel/ai-sdk-migration,posthog/sdk-majors. The existingmigrationguidereaders (removed-parameter tables, removed-member tables) fit none of them.Checklist
testdata/golden/<provider>-<source>.json)testdata/README.mdlists each file: URL, tag commit, date, license, quotestripe-sdks.md,sentry-sdks.md,cloudflare-sdks.md,github-octokit.md,redis-ioredis.md,posthog-go.mdenv.Getmake checkpasses on every branch of the stackReview round 1 (fixed)
replaceLabels→setLabels; a chain ending in a removal is a removal), with a unit test for a two-step chain, a chain ending in a removal and a loop.Deprecated:,Added:) is never read past as an area. This removed false positives in the oldcloudflare/typescript7.2.0 golden (methods listed under "Emptybodyparams removed" still exist): it now pins 7.1.0's plain rename.octokit-net's 0.19.0 event was the same shape: it now pins 0.5.2 (MilestoneUpdate.Numberis now removed).Release
New exported API in
plugins/changelog(File.Notes,File.Cite,NotesSections, the SDKFilevars) → a minor release, not the automatic patch.Calls I made (please check)
plugin.Version.MapsTo(plugin: a version can say which version of another source it pins #226) isn't merged yet, so it isn't filled here. The seven Stripe SDK sources can fill it from their own changelogs ("This release changes the pinned API version to2026-11-18.endive") once it lands.Source ids follow the audit (
sentry/python-changelog,sentry/javascript-changelog), sincesentry/python/sentry/javascriptwere proposed for the migration guides.go:packages list the module path the audit verified (current major); events name the module at each release's major (/v73).Terraform providers have no
Packagesentry (noterraformecosystem inplugin.Ecosystems()); events carry ecosystemterraform.Testdata is trimmed to two release sections per changelog (golden + drop test), each unchanged.
Bullets that remove webhook event names or span attribute names (Stripe
order.payment_failed, Sentrygen_ai.system) are read as removed names: they're strings code uses.Refs #185, #186, #188, #194, #202, #203, #204, #35, #36, #37.
🤖 Generated with Claude Code