Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
Claude finished @adssib's task in 1m 48s —— View job Rules
Bugs
The ioredis ( Verified
I didn't check upstream sources live (e.g. that ioredis 4.31.0 comes right before 5.0.0 on npm). I relied on the saved copies and the PR's statement. Non-blocking
|
| ] | ||
| }, | ||
| "description": "`ISshKeysClient.GetAllForCurrent` was removed in Octokit 0.19.0: code using it fails.", | ||
| "migration_hint": "`ISshKeysClient.GetAllForCurrent()` (Octokit's release notes for 0.19.0)", |
There was a problem hiding this comment.
This event is wrong. The 0.19.0 notes say these ISshKeysClient methods "are marked as obsolete and will be removed in a future release". GetAllForCurrent() still exists in 0.19.0 and code calling it still builds (it only gets a CS0618 warning). This event would open a PR saying "code using it fails", and that isn't true.
Why it happens: the explanation is a plain paragraph, not a bullet, so the classifier only sees the bare bullet `ISshKeysClient.GetAllForCurrent()` under a "Breaking Changes" heading and reads it as a removal. The other five bullets in the list are dropped only because they have arguments, so this release just happens to lose five of six.
Possible fixes:
- Treat a bullet that is only a code span (nothing says what happened to it) as dropped, or
- pin a different octokit.net release where something is actually removed (or a deprecation event, if the classifier can see the "obsolete" sentence).
Either way, 0.19.0 as it stands is a good case for the drop test.
| "symbols": [ | ||
| "octokit.reactions.delete" | ||
| ], | ||
| "replacement": "octokit.reactions.deleteLegacy" |
There was a problem hiding this comment.
The replacement here was removed in the same release. This event tells users to rename reactions.delete → reactions.deleteLegacy, but these same 18.0.0 notes also say "deprecated octokit.reactions.deleteLegacy() has been removed" (that's event 1 in this file). Following the hint gives code that still breaks.
The same thing happens with chained renames in these notes:
- line 1239:
issues.replaceLabels→issues.replaceAllLabels, butreplaceAllLabels→setLabelsin the same release - line 414:
actions.listWorkflowJobLogs→actions.downloadWorkflowJobLogs, butdownloadWorkflowJobLogs→downloadJobLogsForWorkflowRunin the same release
File.Read already checks the release as a whole with added ("the same release adds X back"). A matching check would fix this: when a rename's replacement is itself removed or renamed in the same release, follow the chain to the final name (replaceLabels → setLabels), or emit removed_symbol without a replacement when the chain ends in a removal (delete).
Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Stacked on #227.
What this changes
Three more SDKs, under existing providers:
github/octokit-rest(npm:@octokit/rest) andgithub/octokit-net(nuget:Octokit): read from each GitHub release's notes (Notes: true; neither keeps a changelog file). Versions are the repos' published releases.redis/ioredis(npm:ioredis): CHANGELOG.md at each tag; its majors are headed# [X.0.0].posthog/go(go:github.com/posthog/posthog-go; events name…/v2from 2.0.0): changesets "Major Changes".Kind
changelog; versions from npm, the repo's tags or its releases (no pins).Checklist
git commit -s, DCO)testdata/README.mdlists each file: URL, tag commit, date fetched, license, quoteproviders/github-octokit.md,providers/redis-ioredis.md,providers/posthog-go.mdwritten fromproviders/_template.md, including Why this sourceenv.Getmake checkpasses locally (make pluginsprints the sources as expected)Notes for the reviewer
Saved release notes are GitHub's API JSON trimmed to
html_url,tag_name,name,published_at,body. Saved changelogs are trimmed to two releases' sections (the golden's and the drop test's), each unchanged; only the pinned release's section is read, so the events are the same as from the whole file. Each pinned pair'sprevious_versionis the release before on the registry or tag list (checked live on 2026-11-20).Refs #188, #202, #204 (not closing: the stories' other sources are other kinds or were skipped).
Related PRs
Combined into main: #232 (stack #227 → #228 → #229 → #230 → #231).
🤖 Generated with Claude Code