Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
Claude finished @adssib's task in 2m 3s —— View job Rules
Bugs
No other blocking problems found. I read every golden's events against its saved changelog. Each event is a plain removal named in the bullet's first sentence, and the prose-heavy bullets ("Remove ability to list…", "Remove deprecated error code constants from Verified
Non-blocking
|
| {StripeJava, "21.0.0", "20.136.0", "stripe-java-21.0.0-CHANGELOG.md", "", "20.136.0"}, | ||
| {StripeRuby, "7.0.0", "6.5.0", "stripe-ruby-7.0.0-CHANGELOG.md", "", "6.5.0"}, | ||
| {StripeDotnet, "40.0.0", "39.126.0", "stripe-dotnet-40.0.0-CHANGELOG.md", "", "39.126.0"}, | ||
| {StripePHP, "9.0.0", "8.12.1", "stripe-php-9.0.0-CHANGELOG.md", "", "8.12.0"}, |
There was a problem hiding this comment.
This is the only case where prev (8.12.1) and drop (8.12.0) differ. The saved file's two sections are 9.0.0 and 8.12.0, testdata/README.md describes the trim as "9.0.0 (the golden) and 8.12.0", and all 13 events in golden/stripe-php.json carry "previous_version": "8.12.1".
Can you confirm that a v8.12.1 tag exists in stripe/stripe-php and comes right before v9.0.0? I couldn't check that from CI. If it doesn't exist, the golden records the wrong previous version:
| {StripePHP, "9.0.0", "8.12.1", "stripe-php-9.0.0-CHANGELOG.md", "", "8.12.0"}, | |
| {StripePHP, "9.0.0", "8.12.0", "stripe-php-9.0.0-CHANGELOG.md", "", "8.12.0"}, |
(then regenerate golden/stripe-php.json). If it does exist, please say so in the PR and note in the README row that 8.12.1's section was trimmed out.
|
|
||
| ## What the plugin reads and ignores | ||
|
|
||
| - Reads the release's section only. A bullet counts when it's marked `⚠️` or sits under a breaking or deprecation heading, and its first sentence is a plain template over code spans: `Remove X`, `Remove X from Y`, `Rename X to Y`, `X has been removed`, `Deprecated X in favor of Y`. The pull-request link it starts with is read past. |
There was a problem hiding this comment.
This sentence overstates what the reader does for Stripe. Stripe's newer changelogs (node 10, php 9, and others) group bullets under ### ⚠️ Changed and ### ⚠️ Renamed headings, and the bullets inside carry no ⚠️ of their own. SectionKind (classify.go:23) only treats headings containing "removed", "breaking", "incompatible" or "deprecat" as breaking, so these sections come back as KindNone and are skipped without even being logged as dropped.
For example, stripe-node-10.0.0-CHANGELOG.md:41 reads "Rename InvoiceLineItemListUpcomingParams to InvoiceListUpcomingLinesParams.", which fits the Rename X to Y template exactly, yet golden/stripe-node.json has no renamed_symbol event.
That loses recall, not precision, so it isn't blocking here. But the page should be accurate. Either add it under Known gaps ("bullets under ⚠️ Changed / ⚠️ Renamed headings aren't read"), or have SectionKind treat a heading that starts with ⚠ as breaking (that change belongs in #227).
Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Stacked on #227.
What this changes
Registers Stripe's seven SDK changelogs under the existing
stripeprovider:stripe/python(pypi:stripe),stripe/node(npm:stripe),stripe/go(go:github.com/stripe/stripe-go/v87),stripe/java(maven:com.stripe:stripe-java),stripe/ruby(rubygems:stripe),stripe/dotnet(nuget:Stripe.net),stripe/php(packagist:stripe/stripe-php). Every⚠️bullet that plainly removes or renames a class, method, property, constant or resource is one breaking event.Kind
changelog; versions from the registry or the repo's tags (no pins); each release read at its tag.Checklist
git commit -s, DCO)testdata/README.mdlists each file: URL, tag commit, date fetched, license, quoteproviders/stripe-sdks.mdwritten fromproviders/_template.md, including Why this sourceenv.Getmake checkpasses locally (make pluginsprints the sources as expected)Notes for the reviewer
Saved changelogs are trimmed to two releases' sections (the golden's and the drop test's), each unchanged; only the pinned release's section is read, so the events are the same as from the whole file. Each pinned pair's
previous_versionis the release before on the registry or tag list (checked live on 2026-11-20).Refs #186 (not closing: other sources in the story are other kinds).
Related PRs
Combined into main: #232 (stack #227 → #228 → #229 → #230 → #231).
🤖 Generated with Claude Code