Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
Claude finished @adssib's task in 1m 41s —— View job
Thanks for the careful work here, @adssib: the Python, Go and Terraform sources, the testdata rows and the provider page are all in good shape. One source needs another look. Rules
Bugs
Verified
Non-blocking
|
| #### Empty `body` params removed | ||
|
|
||
| The following methods no longer accept a placeholder `body` param. Remove `body: {}` from call sites. |
There was a problem hiding this comment.
Blocking (precision). All 11 events in golden/cloudflare-typescript.json come from this list, and none of these methods was removed. The changelog says they "no longer accept a placeholder body param", so client.dns.records.scan({ zone_id }) still works. Every event says "X was removed … code using it fails", which is wrong, and each one would become a wrong PR in someone's repo.
Why it happens: the reader puts these bullets in the ### Breaking Changes section (each excerpt says Breaking Changes, not this #### heading). It then reads a bullet made only of code spans as a bare removed name. Two of the bullets also produce bare symbols: enable, forceNotify and deactivate (events 6 and 11).
The real removals in this release are not caught at all: #### Removed Methods (line 11, dropped because of "along with") and #### Removed Types (lines 155–178, e.g. State, CacheVariant, Aegis). So for this file the source currently has precision 0.
Ways to fix it (your choice):
- make
####sub-headings their own sections, and have a bare-name bullet count only under a heading that removes names (not "params removed", "fields removed", "Return Type Changes"); or - leave
cloudflare/typescriptout of this PR until the reader handles Stainless's TS layout, and pin it in a follow-up.
Either way, the golden needs to be regenerated and the PR should explain why the new output is right.
Signed-off-by: adssib <[email protected]>
7.2.0's events came from bare names under a heading about removed body params: the methods still exist. With names alone read only under a Removed heading, 7.2.0 has no event; 7.1.0's rename is the golden. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Stacked on #227.
What this changes
Registers under the existing
cloudflareprovider:cloudflare/typescript(npm:cloudflare),cloudflare/python(pypi:cloudflare),cloudflare/go(go:github.com/cloudflare/cloudflare-go/v7) andcloudflare/terraform(layer infra; no package:terraformisn't a package ecosystem in the registry, events carry ecosystemterraform, packagecloudflare/cloudflare).Kind
changelog; versions from the registry or the repo's tags (no pins); each release read at its tag.Checklist
git commit -s, DCO)testdata/README.mdlists each file: URL, tag commit, date fetched, license, quoteproviders/cloudflare-sdks.mdwritten fromproviders/_template.md, including Why this sourceenv.Getmake checkpasses locally (make pluginsprints the sources as expected)Notes for the reviewer
Saved changelogs are trimmed to two releases' sections (the golden's and the drop test's), each unchanged; only the pinned release's section is read, so the events are the same as from the whole file. Each pinned pair's
previous_versionis the release before on the registry or tag list (checked live on 2026-11-20).Refs #203 (not closing: other sources in the story are other kinds).
Related PRs
Combined into main: #232 (stack #227 → #228 → #229 → #230 → #231).
🤖 Generated with Claude Code