Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
Claude finished @adssib's task in 1m 59s —— View job
Rules
Bugs
Verified
Non-blocking
Thanks for the careful trimming notes and the per-file README rows. They made this easy to check against the sources. |
| "package": "sentry-sdk", | ||
| "change": "removed_symbol", | ||
| "symbols": [ | ||
| "tracing_utils_py2.py" |
There was a problem hiding this comment.
Wrong symbol in this event. tracing_utils_py2.py is a file name, not something code references. The removed module was sentry_sdk.tracing_utils_py2, so anything downstream that searches a repo for tracing_utils_py2.py will never match an import. It was also a Python‑2‑only internal module, and 2.0.0 drops Python 2 entirely, so no code that installs 2.0.0 can be using it.
I'd drop it. The simplest way is to have the shared classifier (classify.go) reject code spans that end in a file extension (.py, .ts, .go, …), log them as dropped, and then regenerate this golden with 7 events. If you'd rather keep it, the symbol should at least be tracing_utils_py2 (the module), and the PR should explain why the event is useful.
| "type": "package_release", | ||
| "ecosystem": "npm", | ||
| "package": "@sentry/node", | ||
| "change": "removed_symbol", |
There was a problem hiding this comment.
Please check which package these removals belong to. Both bullets are feat(core)!, so they're removals from @sentry/core. These events, though, name @sentry/node, and the registration also claims npm:@sentry/browser, which no event ever carries.
If BaseClient and hasTracingEnabled were not exported from @sentry/node 9.x, these events tell @sentry/node users something that doesn't apply to them, and miss the users who import them from @sentry/core. Could you confirm against @sentry/[email protected]'s exports (its index.d.ts) and say what you found in the PR? If they weren't re-exported, the attribution needs fixing. One option is to cover npm:@sentry/core as well and set the package from the bullet's scope; the other is to drop (core)! bullets for this source.
Signed-off-by: adssib <[email protected]>
Signed-off-by: adssib <[email protected]>
Stacked on #227.
What this changes
Registers Sentry's SDK changelogs under the existing
sentryprovider:sentry/python-changelog(pypi:sentry-sdk),sentry/javascript-changelog(npm:@sentry/node, npm:@sentry/browser),sentry/go(go:github.com/getsentry/sentry-go),sentry/dotnet(nuget:Sentry). The audit'ssentry/pythonandsentry/javascriptmigration guides are not added: the Python 2.0 changelog section carries the guide's own Removed/Deprecated lists (a guide source would repeat the same events under another id), and the JavaScript guide's headings are mostly options and behavior (no plain removals to read without false positives).Kind
changelog; versions from the registry or the repo's tags (no pins); each release read at its tag.Checklist
git commit -s, DCO)testdata/README.mdlists each file: URL, tag commit, date fetched, license, quoteproviders/sentry-sdks.mdwritten fromproviders/_template.md, including Why this sourceenv.Getmake checkpasses locally (make pluginsprints the sources as expected)Notes for the reviewer
Saved changelogs are trimmed to two releases' sections (the golden's and the drop test's), each unchanged; only the pinned release's section is read, so the events are the same as from the whole file. Each pinned pair's
previous_versionis the release before on the registry or tag list (checked live on 2026-11-20).Refs #194 (not closing: other sources in the story are other kinds).
Related PRs
Combined into main: #232 (stack #227 → #228 → #229 → #230 → #231).
🤖 Generated with Claude Code