Repository navigation
Conversation
The classifier reads the SDK changelogs' shapes: release-please's "⚠ BREAKING CHANGES", changesets' "Major Changes", Stripe's⚠️ bullets, "**[BREAKING]**" and "feat!:" marks, an area, issue or commit a bullet starts with, passive removals and renames from an owner, and semantic- release's "# [X.0.0]" major headings. A File can read each GitHub release's notes (Notes), list releases from the repo's tags for an ecosystem with no registry lister, and names a Go module at its major. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
Claude finished @adssib's task in 2m 34s —— View job Rules
Bugs (blocking, details inline)
For each, a unit case that must give Verified
I also couldn't write a scratch test file in this environment. The bug cases above come from tracing the regexes and Non-blocking
Nice work on the |
| "`?[0-9a-f]{7,40}`?:?\\s+", | ||
| `Thanks \[@[^\]]+\]\([^)]*\)!\s*-\s*`, | ||
| `(?:[A-Z][\w/]*(?: [A-Z][\w/]*)*) - `, | ||
| `[A-Z][a-zA-Z]+: `, |
There was a problem hiding this comment.
Precision: this alternative (and the Area - and [area] ones above it) also strips a verb label. Under a pure breaking section (### Breaking changes, ⚠ BREAKING CHANGES, and now Major Changes), a bullet like
Deprecated:foo``Added:newClient``Fixed:Foo.bar``
turns into just "foo". The bare template then reads it as breaking removed_symbol foo (classify.go:138), so we'd emit a removal for something that was only deprecated, or even added. Before this PR, these bullets matched no template and were dropped.
One fix: leave a label out of the noise list when it's a change verb (added|fixed|changed|deprecated|renamed|…), or don't apply bare once a noise prefix was stripped. A unit case like {KindBreaking, "Deprecated: +"foo"+", "drop"} would lock it in.
| var ( | ||
| removedActive = regexp.MustCompile(`(?i)^(?:removed|remove|dropped|drop) (?:the )?(?:deprecated )?(?:` + noun + ` )?` + list + | ||
| `(?: ` + noun + `)?(?: from (?:the )?(?:` + noun + ` )?(§)(?: ` + noun + `)?)?(?: \(now called (§)\))?$`) | ||
| removedActive = regexp.MustCompile(`(?i)^(?:removed|removes|remove|dropped|drops|drop) (?:the )?(?:previously )?(?:deprecated )?(?:` + noun + ` )?` + list + |
There was a problem hiding this comment.
Precision: (?:from|in|on|of) now treats any code span after in/on as the owner. clean only rejects owners that aren't identifiers, so these get through:
- "Removed
fooinsetup.py" →setup.py.foo - "Removes
baronios" →ios.bar - "Removed the deprecated
fooinv3" →v3.foo
Each of these would become a wrong symbol in someone's PR. ("in 2.0" is safe: 2.0 isn't an identifier.) Could the owner be limited to from/of, or could in/on require a noun (in the X class)? The cases in the PR (Stripe's from, Neon's from the resource) only need from.
| end := len(lines) | ||
| for j := i + 1; j < len(lines); j++ { | ||
| if strings.HasPrefix(lines[j], "## ") { | ||
| if strings.HasPrefix(lines[j], "## ") || strings.HasPrefix(lines[j], "# ") { |
There was a problem hiding this comment.
Non-blocking (recall only): releaseLines doesn't track code fences, unlike sections. A shell comment in a code example inside a release (```sh then # migrate) now ends the release early, so the bullets after the example are never read. Skipping fenced lines here too, the same way sections does, would fix it.
A rename whose new name the same release renames again or removes now
points to where the chain ends (or to nothing). A bullet of names alone
is a removal only under a Removed heading, and a change word
("Deprecated:") is never read past as an area.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
What this changes
The
changelogkind learns to read the official SDK changelogs the source audit lists, without new kinds:classify.go): release-please's⚠ BREAKING CHANGES, changesets'Major Changes, Stripe's⚠️bullets,**[BREAKING]**, conventional-commitfeat!:marks; an area, issue or commit a bullet starts with (**accounts:**,[#1914](...),fc05013:,Tracing -) is read past; passive removals and renames from an owner (X has been removed from Y,X has been renamed to Y);Class#memberread asClass.member. Still one plain sentence over code spans, or no event.parse.go): Stripe's## <a id="…"></a>X.Y.Z, Datadog's## X.Y.Z/date, semantic-release's# [X.0.0](…)for a major (it used to fold a major into the patch above it); fenced code is never a title or a bullet.File.Notes): an SDK with no changelog file is read from each GitHub release's notes (/repos/{repo}/releases/tags/{tag}), cited by its release page; versions are the repo's published releases. Added because 12 audit candidates have only release notes (the rule: a shared reader once ≥5 need it).Filelists the repo'sTagPrefix + X.Y.Ztags. No pinned tags.…/stripe-go/v73).No source is added here; the stacked PRs register them.
Checklist
git commit -s, DCO)testdata/README.mdlists each file (the two version-list fixtures, written for the test)**api:** add support for new API version …under⚠ BREAKING CHANGES)providers/…: n/a (no source)env.Getmake checkpasses locallyNotes for the reviewer
docs/which-kind.md,docs/writing-a-plugin.md,AGENTS.mdlayout line.File.Notes,File.Cite,NotesSections) → minor bump when released.Part of #185.
Calls I made (please check)
core/versions.MaxPages(1,000 tags), enough for the 3-year window.Related PRs
Combined into main: #232 (stack #227 → #228 → #229 → #230 → #231).
🤖 Generated with Claude Code