Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
…alls back on 503 too Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
Claude encountered an error after 1m 35s —— View job
Rules
Bugs
Verified
Non-blocking
|
| var made []event.Event | ||
| var details []string | ||
| for _, e := range after { | ||
| if had[e.key()] || e.Date < to.Version.ID || e.Criticality != "breaking" { |
There was a problem hiding this comment.
Precision, worth a look (not blocking): this only compares against the previous commit. If a commit drops entries that are still upcoming (a bad regeneration or a reverted PR) and the next commit puts them back, every restored entry passes e.Date >= to.Version.ID and gets a second deprecation event. The fingerprint differs because Version is the new commit's date, so nothing downstream deduplicates it. The 2026-01-05..08 case is handled only because those entries were already past-dated.
One option: also skip an entry whose location@date was in the file in any earlier version this run has seen. Another: emit only when the location (at any date) is new, and treat a moved date as the gap the provider page already lists. A drop test that removes and restores a future-dated entry would pin either fix.
| if !ok || typ == "" || rest == "" { | ||
| return event.Subject{}, false | ||
| } | ||
| if strings.HasSuffix(typ, "Input") || typ == "Query" || typ == "Mutation" || typ == "Subscription" { |
There was a problem hiding this comment.
Mapping (non-blocking, you flagged it): two locations land in an odd place here.
- A root field itself (
Query.someField,Mutation.someMutation, with no argument) becomes arequest_parameterofPOST /graphqlwith propertyQuery.someField. It's a whole operation going away, not a parameter. - A non-root field's argument (
Repository.issues.filterBy) goes to theschema_propertybranch withProperty: "issues.filterBy",Side: response. An argument is sent, not received.
Neither emits a wrong fact, since the property string is still the exact location. But a client that matches on kind/side may look in the wrong place. Consider documenting both cases on the provider page, or splitting on the number of dots.
…t announced twice Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
|
@claude review Round 2. Fixed: |
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
|
@claude review Round 3 (the round-2 run failed inside the Action before reviewing). Since round 1: |
Needs a minor release after merge. Exported API changed:
catalog.Commands,catalog.UpcomingChanges,versions.PyPIReleasesWithYanked,versions.FirstOfMajor,retire.Format,retire.Gemini,retire.Vertex.catalog.Catalogandcatalog.Plugin;members.NumPy2,PostHog8andNewRelic11(nowNumPy,PostHog,NewRelic, with noReleaseorDocsRef);migrationguide.Guide'sGuideURLandRead;sdkguide.FirstOfMajorandAnthropicV1;changelog.Textual0860andUrllib3200.Closes #179
Closes #222
Closes #223
Closes #224
The combined branch of the stack, where CI and the review run. Each part has its own PR, with the details and the issue's checklist:
_test.go;TestNoPinnedReleaseInPluginCoderedis/commandsreadssrc/commands/at every Redis release tag (redis/redis), not the archived redis-docget-convex→convexorggoogle/gemini-models(notices; Markdoc tables)google/vertex-model-retirements(notices; HTML tables)github/graphql(catalog; GitHub's GraphQL upcoming-changes file, commit by commit)Sources added
google/gemini-modelsgoogle/vertex-model-retirementsgithub/graphqlEvery URL was re-checked on 2026-11-21 before it was written. Each source has its metadata in the registration (I read the words), a golden, a drop test,
testdata/README.mdrows and a provider page with Why this source.High and medium notices/catalog candidates from the audit that aren't built, and why
None of these is waiting on a new kind. Each needs a contract subject, a different reader input, or has no source precise enough to emit valid events:
openai/deprecations(endpoint table)/v1/prompts,/v1/audio/translations) but no method, and the contract'soperationisMETHOD /path. Guessing the method isn't reading the page. Needs a path-wide operation in the contract.anthropic/api-noticesmongodb/server,neon/postgres-versions,redis/software-lifecycle,elastic/eolelastic/eolis also JS-rendered (unverified).newrelic/eol(RSS)vercel/runtimesci_runtime(a CI platform).supabase/changelog(RSS)gitlab/rest-deprecationsgitlab/deprecations(catalog)github/runner-images(issues)ci_runtime, but needs a reader for an issues list. That list changes on every comment (counts, timestamps), so a living-page read would snapshot it every run and the citation check would fail on churn. Needs a reader that hashes only the announcements. Meanwhilegithub/actions(the changelog feed) covers runner image retirements.cloudflare/workers-compat-flags(catalog)openai/changelog,google/gemini-changelog,github/changelog,cloudflare/changelog,vercel/changelog,neon/changelogopenai/models,google/gemini-models,github/actions,cloudflare/api).google/vertex-deprecationsgithub/rest-versionsgithub/api(the OpenAPI diff) covers those versions.gitlab/deprecations-page,gitlab/graphql,gitlab/breaking-windowsgitlab/graphql's removed items could map likegithub/graphql; left for a follow-up.elastic/elasticsearch-deprecationssupabase/breaking-changesCalls I made (please check)
redis/redissrc/commands/at release tags, notredis/docsdata/commands.json. The docs file's history would give 126 false removals (module commands dropped and put back) and once deletes the file. See redis: read the commands at each release tag of redis/redis #234.gemini-2.5-pro: 2026-12-01 on the Gemini API, 2026-10-20 on Vertex AI).google/vertex-ai-models(the feed) stays alongside the new Vertex AI table.api_operation(see add github/graphql: announced GraphQL removals #239).plugins/changelog/changelog.go(no pinned release in plugin code: every major's removed-members guide #233 movesTextual0860/Urllib3200intopinned_test.go) and the kinds table indocs/writing-a-plugin.md. Both are small; whichever merges second resolves them. That stack adds no release pins of its own, soTestNoPinnedReleaseInPluginCodestays green after it.Checks
make checkpasses on every branch of the stack (go1.27.1).convex.json(source_urlorg only, convex: read from the convex org #236) and the new ones (redis-commands,google-gemini-models,google-vertex-model-retirements,github-graphql).Related PRs
🤖 Generated with Claude Code