Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: adssib <[email protected]>
8 tasks done
|
Claude finished @adssib's task in 1m 32s —— View job ✅ Ready to merge: the source moves to a maintained, release-tagged file. Metadata, provider page, golden, drop test and source rows are all complete, and every check passes locally. Rules
BugsNone found. A few things I checked:
Verified
Non-blocking
|
| Type: event.SubjectPackageRelease, Ecosystem: c.Ecosystem, Package: c.Package, | ||
| Change: event.PackageRemovedSymbol, Symbols: []string{name}, | ||
| }, | ||
| Description: fmt.Sprintf("%s is gone in Redis %s (it was in %s): calling it fails.", name, to.Version.ID, from.Version.ID), |
There was a problem hiding this comment.
Non-blocking: Commands is now the generic reader the scaffold hands to every new catalog provider (cmd/new-plugin/formats.go), but this description says "Redis" for all of them. A second provider would emit "X is gone in Redis 1.2.0". You could add a Product string field ("Redis") or reuse the provider's name, for example:
Description: fmt.Sprintf("%s is gone in %s %s (it was in %s): calling it fails.", name, c.Product, to.Version.ID, from.Version.ID),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #233
Closes #222
What this changes
redis/commandsreadcommands.jsonfromredis/redis-doc. That repo is archived: the file last changed on 2023-10-24 and lists 370 commands. It now reads the command definitions in the server's own source,src/commands/*.jsonin redis/redis, at every final release tag (listed from GitHub releases and ordered by version, because Redis patches older lines after newer ones ship).src/commands/. A command file missing at the next release is aremoved_symbolevent, citing the file at the older tag. Only removed files are fetched.src/commands/, so there's nothing to read (skipped).catalog.Commandshere;catalog.UpcomingChangescomes later in this stack).catalog.Catalog/catalog.Pluginare deleted, along with the old fixtures. The scaffold and the docs follow.Why
redis/redisand notredis/docsdata/commands.jsonThe issue named both. I diffed the history of each (2026-11-20):
redis/docsdata/commands.json(5 commits since 2024-02):2f513f2drops 126 module commands (BF.*,CF.*,FT.*…) that Redis never removed, and later commits put them back;9740114deletes the file;Every one of those would be a false event.
redis/redissrc/commands/: what the server and redis.io's command reference are generated from, at the release tags a team runs. Across every final release from 7.0.0 to 8.10.3, no command was removed, which is the correct answer for Redis. The one removal anywhere since 7.0 is between pre-release tags: GCRA and GCRASETVALUE, added in the 8.8 milestone builds and gone at 8.8-rc1. The golden pins that pair.Recorded under Why this source in
providers/redis.md.#222's checklist
providers/redis.md(redis/redissrc/commands/, see above)testdata/golden/redis-commands.json). There was no golden before, only assertions over the redis-doc excerpts, which are deleted with that source.Checklist
testdata/README.mdrows: URL, date, license, quoteproviders/redis.mdrewritten, with Why this sourcemake checkpassesRelated PRs
🤖 Generated with Claude Code